Boost C++ Libraries: Ticket #13457: Windows port for 1.66.0 incorrectly includes NTVERP.H

component changed; owner set

Wed, 02 May 2018 01:18:56 GMT

owner set to Andrey Semashev
component None → winapi

status changed; resolution set

Andrey Semashev — Thu, 03 May 2018 01:32:34 GMT

status new → closed
resolution → invalid

The boost/predef/platform/windows_uwp.h header is part of Boost.Predef. Please, report the problem here.

In my opinion though, you have to define any version macros before including *any* headers, Boost or not. And ntverp.h is essential as it allows Boost to discover Windows SDK version, I see no way around including it.

Thu, 03 May 2018 01:45:09 GMT

It is common to share a Version.h header file between resource (.rc) files and source files (.cpp), to give the program access to the version information placed in the executable's version info section. Moving the definitions of the version macros before the header includes solves nothing; the macros are still re-defined because you're including NTVERP.H. Why not check to see if the macros are already defined before including NTVERP.H?

Andrey Semashev — Thu, 03 May 2018 02:05:40 GMT

Arguably, you're not defining macros like VER_PRODUCTBUILD. You're not supposed to, anyway, because that is the Windows SDK version macro.

I'm not sure what version information you mean, but if this is the target Windows version defined by _WIN32_WINNT or the API family defined by WINAPI_FAMILY then defining those in a header is error-prone because it can easily get you into trouble if you mess up include order.

Thu, 03 May 2018 02:41:23 GMT

In File Explorer, when you right-click on an executable and select the details tab, what you see is the version information that was stored in a resource section in the executable. As I mentioned, the most common paradigm is to define the version info in a header file (version.h), which is included by both the resource file (resources.rc) and the cpp file, thus giving the cpp file access to the version info, for outputting in a banner or in response to a -v command.

Thu, 03 May 2018 02:47:12 GMT

How about putting your include of NTVERP.h into its own namespace so that you don't pollute the global namespace?

Andrey Semashev — Thu, 03 May 2018 08:35:55 GMT

In File Explorer, when you right-click on an executable and select the details tab, what you see is the version information that was stored in a resource section in the executable.

I don't see how it is related to macros defined in ntverp.h. Which macros must you define in your header that are also defined in ntverp.h?

How about putting your include of NTVERP.h into its own namespace so that you don't pollute the global namespace?

We're talking about macros, they don't respect C++ namespaces.