Boost C++ Libraries: Ticket #13505: graph/detail/array_binary_tree.hpp:45:18: error: unknown template name 'iterator'

component changed; owner set

Michel Morin — Fri, 30 Mar 2018 21:00:37 GMT

owner set to Jeremiah Willcock
component None → graph

What happens if you add #include <boost/iterator.hpp> to boost/graph/detail/array_binary_tree.hpp?

Fri, 30 Mar 2018 22:20:29 GMT

this fixed the issue for me, thanks!

Sat, 31 Mar 2018 06:12:05 GMT

p.s. i think the issue would have been fixed by this PR from Jan 2018 https://github.com/boostorg/graph/pull/101 Hopefully, it will be merged before 1.67.0 stable release.

Michel Morin — Sat, 31 Mar 2018 08:32:29 GMT

p.s. i think the issue would have been fixed by this PR

Right, since boost/iterator.hpp is deprecated, that PR is a better fix. But I'm 95% sure that the PR will not be merged for Boost 1.67; the changeset is a bit too large to be merged within the Boost 1.67 timeframe (and the development of Boost.Graph is not so active these days).

If this is critical for the dealii project, I would recommend the following:

First, submit a PR to Boost.Graph that #includes the missing header.
Then, post a message to the Boost developers' ML (you need to describe the ML to post a message) with a subject something like "[1.67] Missing include in Boost.Graph" and say
- dealii cannot be built without your PR (if this is a regression, please say so).
- also mention that boostorg/graph #101 would be a better fix.

Sat, 31 Mar 2018 08:50:05 GMT

thanks for the suggestion, I have done all in the above.

Michel Morin — Sat, 31 Mar 2018 10:24:28 GMT

Thanks Denis! Let's see if it goes to Boost 1.67. (Your first post to the boost-dev ML will be sent after moderators authorize it.)