Boost C++ Libraries: Ticket #1410: Missing include statements and other errors

attachment set

jensseidel@… — Mon, 05 Nov 2007 14:36:23 GMT

attachment → boost.wave.diff

Sun, 02 Dec 2007 15:56:08 GMT

No action happened until today. Fixing these issues by applying (at least parts) of the patch takes you not a long time and fixes some errors. Please note that even more needs to be fixed and I will definitively not look into it if you ignore existing patches.

status changed; resolution set

Hartmut Kaiser — Sun, 02 Dec 2007 17:18:56 GMT

status new → closed
resolution → fixed

(In [41588]) Applied patch supplied by Jens Seidel. Fixed #1410.

Hartmut Kaiser — Sun, 02 Dec 2007 17:20:59 GMT

Sorry, I must have missed your patch. It's applied now in the trunk. Thanks!

Sun, 02 Dec 2007 18:03:52 GMT

Replying to hkaiser:

Sorry, I must have missed your patch.

Can happen ...

It's applied now in the trunk. Thanks!

Great!

OK, now I started by script again and compiled each header file (included in a empty .cpp file) again and got much better results. Nevertheless it stops multiple times because of

boost/wave/wave_config.hpp:408:2: error: #error "Boost.Wave: the constant PHOENIX_LIMIT must be at least defined to 6" " to compile the library."

You probably have to fix it. Please note that the output contained "at least defined to 4" but the test if for <6, so I changed this as well.

I attached the output of my script please check!

attachment set

Sun, 02 Dec 2007 18:04:26 GMT

attachment → wave.txt

Hartmut Kaiser — Sun, 02 Dec 2007 19:08:43 GMT

Applied some additional fixes in trunk (rev. 41590). Thanks!

Sun, 02 Dec 2007 20:34:23 GMT

Replying to hkaiser:

Applied some additional fixes in trunk (rev. 41590). Thanks!

Great, but still not perfect.

What compiler do you use? I get using g++ (I think I used the 4.3 snapshot):

error: there are no arguments to 'spirit_assign_actor' that depend on a template parameter, so a declaration of 'spirit_assign_actor' must be available

According to http://gcc.gnu.org/onlinedocs/gcc/Name-lookup.html g++ checks this since 3.4 which is a rather old version.

It took me a while to fix it as I normally just add a this-> which fails for static functions but I found a solution and attached a patch. This is the last error in wave!

So you see that checking each header file on it's own is a trivial but important test.

attachment set

Sun, 02 Dec 2007 20:34:47 GMT

attachment → boost.wave.diff2

Sun, 02 Dec 2007 20:37:47 GMT

PS: One further question. As you managed to get the PHOENIX_LIMIT error go away, how about removing the comment boost/spirit/attribute.hpp sets PHOENIX_LIMIT to 3 in boost/wave/wave_config.hpp?

Or is including boost/spirit/attribute.hpp before boost/wave/wave_config.hpp still a bad idea and needs to be fixed in boost/spirit/attribute.hpp (and maye other files as well)?

Eric Niebler — Sun, 02 Dec 2007 23:20:20 GMT

(In [41596]) Merged revisions 41488-41595 via svnmerge from https://svn.boost.org/svn/boost/trunk

........

r41489 | djowel | 2007-11-30 02:07:41 -0800 (Fri, 30 Nov 2007) | 1 line

fixed link

........

r41493 | grafik | 2007-11-30 07:56:42 -0800 (Fri, 30 Nov 2007) | 1 line

Mode proposal.pdf to new web site. (fixes #1364)

........

r41494 | grafik | 2007-11-30 07:58:59 -0800 (Fri, 30 Nov 2007) | 1 line

Obsolete. (fixes #1362)

........

r41497 | grafik | 2007-11-30 08:21:49 -0800 (Fri, 30 Nov 2007) | 1 line

Move the content of old more/links.html doc to new web site. (fixes #1360).

........

r41500 | bemandawes | 2007-11-30 08:44:23 -0800 (Fri, 30 Nov 2007) | 1 line

Refresh examples, add example build script, reflect that in docs. Apply suggestions from Darren Cook.

........

r41501 | grafik | 2007-11-30 09:13:02 -0800 (Fri, 30 Nov 2007) | 1 line

Obsolete. (fixes #1365)

........

r41502 | grafik | 2007-11-30 09:16:00 -0800 (Fri, 30 Nov 2007) | 1 line

Obsolete. (fixes #1348)

........

r41504 | grafik | 2007-11-30 09:45:24 -0800 (Fri, 30 Nov 2007) | 1 line

Obsolete. (fixes #1345)

........

r41505 | anthonyw | 2007-11-30 10:38:21 -0800 (Fri, 30 Nov 2007) | 1 line

interruptible_wait (and hence condition timed_wait) now uses a WaitableTimer where possible, to be robust in the face of clock changes

........

r41506 | danieljames | 2007-11-30 11:28:46 -0800 (Fri, 30 Nov 2007) | 2 lines

Frank Mori Hess's patch to get the documentation building.

........

r41511 | danieljames | 2007-11-30 12:06:44 -0800 (Fri, 30 Nov 2007) | 3 lines

Remove the formal review schedule, as it has been moved to the new site. Fixes #1351

........

r41519 | djowel | 2007-11-30 17:11:44 -0800 (Fri, 30 Nov 2007) | 1 line

remove old unused file

........

r41521 | dave | 2007-11-30 18:15:17 -0800 (Fri, 30 Nov 2007) | 7 lines

Boost.Python:

Workarounds for many SunCC 5.9 bugs
Suppression of many SunCC 5.9 warnings
Improve the style of some test invocations in Jamfile

........

r41526 | dave | 2007-11-30 21:07:13 -0800 (Fri, 30 Nov 2007) | 2 lines

Fixed grammar in error message

........

r41529 | niels_dekker | 2007-12-01 04:14:37 -0800 (Sat, 01 Dec 2007) | 1 line

Added value_init tests, based upon GCC bug report by Jonathan Wakely. Added URL to Borland bug report.

........

r41530 | niels_dekker | 2007-12-01 05:57:06 -0800 (Sat, 01 Dec 2007) | 1 line

Marked value_init_test failures on GCC as "expected failures", referring to ticket #1491

........

r41532 | vladimir_prus | 2007-12-01 06:56:23 -0800 (Sat, 01 Dec 2007) | 2 lines

Change the detection of 64-bit windows to handle EM64T processors.

........

r41534 | danieljames | 2007-12-01 08:44:20 -0800 (Sat, 01 Dec 2007) | 4 lines

Transfer the rest of the version history to the new website.

Fixes #1374.

........

r41535 | grafik | 2007-12-01 08:44:54 -0800 (Sat, 01 Dec 2007) | 1 line

Plug memory leak when closing out actions. Thanks to Martin Kortmann for finding this.

........

r41538 | vladimir_prus | 2007-12-01 09:56:47 -0800 (Sat, 01 Dec 2007) | 2 lines

Document 64-bit compilation.

........

r41539 | danieljames | 2007-12-01 09:58:44 -0800 (Sat, 01 Dec 2007) | 2 lines

Mark hash_long_double_test as failing on all PA-RISC compilers.

........

r41540 | igaztanaga | 2007-12-01 10:01:15 -0800 (Sat, 01 Dec 2007) | 1 line

Simplified mutexes for systems with no _POSIX_TIMEOUTS.

........

r41542 | vladimir_prus | 2007-12-01 11:07:22 -0800 (Sat, 01 Dec 2007) | 4 lines

Add <testing.arg> functionality to unit-test rule.

Patch from Mark Desnoyer.

........

r41544 | jhunold | 2007-12-01 11:27:06 -0800 (Sat, 01 Dec 2007) | 2 lines

Silence compiler by adding cosmetic virtual destructors.

........

r41547 | vladimir_prus | 2007-12-01 12:06:43 -0800 (Sat, 01 Dec 2007) | 1 line

Document runtime-link

........

r41548 | grafik | 2007-12-01 12:17:52 -0800 (Sat, 01 Dec 2007) | 1 line

Add support for detection and building with vc9. (fixes #1490)

........

r41549 | jhunold | 2007-12-01 12:24:51 -0800 (Sat, 01 Dec 2007) | 2 lines

Silence compiler by adding cosmetic virtual destructors.

........

r41550 | jhunold | 2007-12-01 12:26:37 -0800 (Sat, 01 Dec 2007) | 3 lines

Remove unused paramters. Add -Wextra to gcc flags to enable more warnings.

........

r41552 | grafik | 2007-12-01 12:40:56 -0800 (Sat, 01 Dec 2007) | 1 line

Remove borders from simple list tables.

........

r41553 | grafik | 2007-12-01 12:42:27 -0800 (Sat, 01 Dec 2007) | 1 line

Remove borders from simple list tables.

........

r41554 | t_schwinger | 2007-12-01 12:52:00 -0800 (Sat, 01 Dec 2007) | 3 lines

Using central stylesheet now.

........

r41555 | vladimir_prus | 2007-12-01 13:26:09 -0800 (Sat, 01 Dec 2007) | 1 line

Document STLport

........

r41556 | grafik | 2007-12-01 13:53:47 -0800 (Sat, 01 Dec 2007) | 1 line

Document various "new" features, and add in the history till now for 3.1.16. (fixes #1445 #1447 #1448)

........

r41557 | vladimir_prus | 2007-12-01 14:31:04 -0800 (Sat, 01 Dec 2007) | 1 line

Remove unused method

........

r41562 | grafik | 2007-12-01 17:59:02 -0800 (Sat, 01 Dec 2007) | 1 line

No-op no-empty action.

........

r41563 | grafik | 2007-12-01 18:03:48 -0800 (Sat, 01 Dec 2007) | 1 line

';' can't be a no-op on nix.

........

r41565 | grafik | 2007-12-01 20:06:28 -0800 (Sat, 01 Dec 2007) | 1 line

Remove outdated release procedures, and move content to wiki. Content moved to <http://svn.boost.org/trac/boost/wiki/ReleasePractices/Procedures> and <http://svn.boost.org/trac/boost/wiki/ReleasePractices/ManagerCheckList>. (fixes #1366 #1367)

........

r41566 | grafik | 2007-12-01 20:22:34 -0800 (Sat, 01 Dec 2007) | 1 line

Remove obsolete images. (fixes #1257)

........

r41568 | grafik | 2007-12-01 22:56:38 -0800 (Sat, 01 Dec 2007) | 1 line

"Who's Using Boost?" content moved to new web site.

........

r41569 | grafik | 2007-12-01 23:02:12 -0800 (Sat, 01 Dec 2007) | 1 line

"Who's Using Boost?" content moved to new web site.

........

r41571 | igaztanaga | 2007-12-02 01:25:53 -0800 (Sun, 02 Dec 2007) | 1 line

Added missing #include <typeinfo> overwritten by previous commit

........

r41572 | danieljames | 2007-12-02 01:59:15 -0800 (Sun, 02 Dec 2007) | 1 line

Add some parameters to the standalone hash build.

........

r41574 | danieljames | 2007-12-02 02:23:58 -0800 (Sun, 02 Dec 2007) | 2 lines

Initialise svnmerge.

........

r41575 | danieljames | 2007-12-02 02:25:22 -0800 (Sun, 02 Dec 2007) | 1 line

Fix the navbar links.

........

r41577 | jhunold | 2007-12-02 03:51:08 -0800 (Sun, 02 Dec 2007) | 3 lines

Revert revisions 41544 and 41549. See http://lists.boost.org/Archives/boost/2007/12/131116.php for details.

........

r41580 | danieljames | 2007-12-02 05:47:31 -0800 (Sun, 02 Dec 2007) | 2 lines

Revert a change I mean to make on the fix-links branch.

........

r41582 | danieljames | 2007-12-02 06:15:25 -0800 (Sun, 02 Dec 2007) | 5 lines

Remove formal_review_process, it looks like I forgot to when I updated the version in the new site.

Refs #1350.

........

r41587 | grafik | 2007-12-02 09:03:43 -0800 (Sun, 02 Dec 2007) | 1 line

Obsolete.

........

r41588 | hkaiser | 2007-12-02 09:18:54 -0800 (Sun, 02 Dec 2007) | 1 line

Applied patch supplied by Jens Seidel. Fixed #1410.

........

r41590 | hkaiser | 2007-12-02 11:08:13 -0800 (Sun, 02 Dec 2007) | 1 line

Wave: More fixes to allow error free compilation of every header on its own.

........

r41592 | grafik | 2007-12-02 12:15:25 -0800 (Sun, 02 Dec 2007) | 1 line

Support building of universal binaries using architecture options. Thanks to Mat Marcus. (fixes #552 #1342 #989)

........

r41593 | niels_dekker | 2007-12-02 14:10:45 -0800 (Sun, 02 Dec 2007) | 1 line

Added missing GCC version (4.0) to expected GCC failures of value_init_test

........

anonymous — Mon, 03 Dec 2007 00:35:03 GMT

Replying to Jens Seidel <jensseidel@users.sf.net>:

Replying to hkaiser:

Applied some additional fixes in trunk (rev. 41590). Thanks!

Great, but still not perfect.

What compiler do you use? I get using g++ (I think I used the 4.3 snapshot):

error: there are no arguments to 'spirit_assign_actor' that depend on a template parameter, so a declaration of 'spirit_assign_actor' must be available

According to http://gcc.gnu.org/onlinedocs/gcc/Name-lookup.html g++ checks this since 3.4 which is a rather old version.

This problem occurs only when compiling the headers standalone. For this reason it never got noticed.

It took me a while to fix it as I normally just add a this-> which fails for static functions but I found a solution and attached a patch. This is the last error in wave!

So you see that checking each header file on it's own is a trivial but important test.

This is fixed now, even if I did it in a completely different manner. Thanks!

anonymous — Mon, 03 Dec 2007 00:36:24 GMT

Replying to Jens Seidel <jensseidel@users.sf.net>:

PS: One further question. As you managed to get the PHOENIX_LIMIT error go away, how about removing the comment boost/spirit/attribute.hpp sets PHOENIX_LIMIT to 3 in boost/wave/wave_config.hpp?

Or is including boost/spirit/attribute.hpp before boost/wave/wave_config.hpp still a bad idea and needs to be fixed in boost/spirit/attribute.hpp (and maye other files as well)?

I'ld rather leave it in, because if somebody sets PHOENIX_LIMIT before including the wave_config.hpp things go wrong with completely unrelated errors.

Thanks again! Regards Hartmut