Boost C++ Libraries: Ticket #1427: [iterator] transform_iterator should use boost::result_of to determine functor result type

attachment set

debionne@… — Fri, 31 Jul 2009 08:53:33 GMT

attachment → patch_transform_iterator

transform_iterator.hpp patch for boost 1.39

attachment set

debionne@… — Fri, 31 Jul 2009 08:54:21 GMT

attachment → patch_transform_iterator_test

transform_iterator_test.cpp patch for boost 1.39

debionne@… — Fri, 31 Jul 2009 09:03:59 GMT

The patchs above changes the mechanism that computes the default result type of the given UnaryFunction to use boost::result_of. Consequently, transform_iterator now support polymorphic object function (i.e. function wich result type depends on the arguments type). Such a function object must implement the result_of 'protocol', that is implement a nested result structure such as :

template <class FArgs> struct result; template <class F, class T> struct result<F(T)> {typedef whatever<T>::type type};

A polymorphic object function is added to the tests.

status changed; resolution set

Jeremiah Willcock — Wed, 09 Jun 2010 01:08:46 GMT

status new → closed
resolution → fixed

(In [62625]) Applied patches from #1427; fixes #1427

status changed; resolution deleted

mimomorin@… — Sat, 11 Dec 2010 00:38:58 GMT

status closed → reopened
resolution fixed

Reopened, until merged to release.

Marshall Clow — Sat, 08 Jan 2011 18:38:47 GMT

(In [67792]) Merging fixes to release; fixes #2294 fixes #4918 fixes #3645 refs #2823 refs #1427 refs #2893

status changed; resolution set

Marshall Clow — Sat, 08 Jan 2011 18:48:20 GMT

status reopened → closed
resolution → fixed

status changed; resolution deleted

mimomorin@… — Sun, 09 Jan 2011 05:51:38 GMT

status closed → reopened
resolution fixed

r67792 does not seem to do anything with transform_iterator.hpp. Is there something missing?

status changed; resolution set

Marshall Clow — Thu, 13 Jan 2011 01:25:14 GMT

status reopened → closed
resolution → fixed

(In [68076]) Merging fixes to release; Fixes #1427

status changed; resolution deleted

mimomorin@… — Mon, 17 Jan 2011 13:03:27 GMT

status closed → reopened
resolution fixed

I've experimented with the updated transform_iterator, and found a discrepancy between code and document.

The document says that the (default) reference member of transform_iterator is

result_of<UnaryFunction(iterator_traits<Iterator>::reference)>::type

But the code uses

result_of<UnaryFunction(iterator_traits<Iterator>::value_type)>::type

We should modify the code to use reference instead of value_type, because

the discrepancy is confusing for users
reference better interacts with the result_of protocol than value_type

The current code in trunk/release causes compiler error in the following code:

#include <boost/array.hpp>
#include <boost/iterator/transform_iterator.hpp>
#include <boost/spirit/include/phoenix.hpp>
int main(int argc, char* argv[])
{
    boost::array<int, 3> ar = {{}};
    *boost::make_transform_iterator(ar.cbegin(), boost::phoenix::arg_names::_1);
    return 0;
}

I will attach a patch for fixing this.

Sorry for reopening this ticket repeatedly.

attachment set

mimomorin@… — Mon, 17 Jan 2011 13:10:36 GMT

attachment → transform_iterator.patch

A patch against trunk (boost/iterator/transform_iterator.hpp)

attachment set

mimomorin@… — Mon, 17 Jan 2011 13:11:28 GMT

attachment → transform_iterator_test.patch

A patch against trunk (libs/iterator/test/transform_iterator_test.cpp)

Marshall Clow — Mon, 17 Jan 2011 14:53:48 GMT

I've committed these patches as [68205]

Daniel James — Fri, 28 Jan 2011 08:40:31 GMT

(In [68524]) Revert [68076], refs #1427.

Will try to fix this properly in 1.47.

status changed; resolution set

Daniel James — Tue, 29 Mar 2011 21:31:32 GMT

status reopened → closed
resolution → fixed

(In [70715]) Iterator: Use boost::result_of to determine nested result type of function in transform_iterator. Fixes #1427.