Boost C++ Libraries: Ticket #1454: Minor compilation errors with g++ -pedantic

attachment set

Sat, 17 Nov 2007 20:12:45 GMT

attachment → boost.math.diff

Sun, 02 Dec 2007 16:07:57 GMT

Why did you ignore this patch until today? It fixes some compilation errors!

status changed

John Maddock — Tue, 11 Dec 2007 09:41:16 GMT

status new → assigned

status changed; resolution set

John Maddock — Tue, 11 Dec 2007 16:37:22 GMT

status assigned → closed
resolution → fixed

(In [41966]) Fixes #1454.

John Maddock — Tue, 11 Dec 2007 16:44:20 GMT

(In [41967]) Fixes #1454.

Eric Niebler — Tue, 11 Dec 2007 22:00:09 GMT

(In [41984]) Merged revisions 41954-41983 via svnmerge from https://svn.boost.org/svn/boost/trunk

........

r41955 | schoepflin | 2007-12-10 05:40:56 -0800 (Mon, 10 Dec 2007) | 1 line

Treated Rogue Wave library concept check failure on Tru64/CXX.

........

r41956 | dave | 2007-12-10 07:19:21 -0800 (Mon, 10 Dec 2007) | 2 lines

SunPro 5.9 can't detect lvalue returns

........

r41957 | t_schwinger | 2007-12-10 10:26:38 -0800 (Mon, 10 Dec 2007) | 3 lines

changes msvc-7.1 to msvc-7.1*

........

r41966 | johnmaddock | 2007-12-11 08:37:22 -0800 (Tue, 11 Dec 2007) | 1 line

Fixes #1454.

........

r41968 | johnmaddock | 2007-12-11 09:16:21 -0800 (Tue, 11 Dec 2007) | 1 line

Fixes #1504.

........

r41970 | johnmaddock | 2007-12-11 09:19:03 -0800 (Tue, 11 Dec 2007) | 1 line

Fixes #1455.

........

r41973 | johnmaddock | 2007-12-11 09:28:15 -0800 (Tue, 11 Dec 2007) | 1 line

Fixes #1471.

........

r41976 | johnmaddock | 2007-12-11 10:51:57 -0800 (Tue, 11 Dec 2007) | 1 line

Fixes #1474.

........

r41979 | vladimir_prus | 2007-12-11 11:41:47 -0800 (Tue, 11 Dec 2007) | 1 line

Put add-usage-requirements back

........

r41980 | vladimir_prus | 2007-12-11 11:45:37 -0800 (Tue, 11 Dec 2007) | 1 line

Implement ISFILE for real

........

r41981 | vladimir_prus | 2007-12-11 11:46:19 -0800 (Tue, 11 Dec 2007) | 2 lines

When searching for headers, ignore directories, just like gcc does.

........

r41983 | bgubenko | 2007-12-11 12:43:11 -0800 (Tue, 11 Dec 2007) | 1 line

remove conditionalization for aCC: this header works with gcc on HP-UX also

........

status changed; resolution deleted

Wed, 12 Dec 2007 20:10:12 GMT

status closed → reopened
resolution fixed

It's not yet fully applied. The typo in asinh.hpp is for example still unfixed, ...

I also added myself to CC: (is this necessary?) but got no "bug is closed" mail. Searching for closed bugs is also nearly impossible with trac and needs to be improved.

status changed; resolution set

John Maddock — Thu, 13 Dec 2007 18:45:59 GMT

status reopened → closed
resolution → fixed

(In [42012]) Fixes #1454.

Previous fix was incomplete, so added new tests, confirmed problem report, and added fixes.

All the tests now compile cleanly with g++ -pedantic -Wall -Wno-long-long (checked with gcc-4.4.1 and 3.4.4).

Eric Niebler — Sat, 15 Dec 2007 20:38:43 GMT

(In [42083]) Merged revisions 41984-42066 via svnmerge from https://svn.boost.org/svn/boost/trunk

........

r41986 | rwgk | 2007-12-11 21:39:45 -0800 (Tue, 11 Dec 2007) | 1 line

undo revision 41404; see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34238

........

r41987 | jano_gaspar | 2007-12-12 02:40:31 -0800 (Wed, 12 Dec 2007) | 1 line

circular_buffer: g++ warning fix

........

r41988 | dgregor | 2007-12-12 05:51:21 -0800 (Wed, 12 Dec 2007) | 1 line

Fix typo in maintainers file

........

r41990 | djowel | 2007-12-12 07:48:49 -0800 (Wed, 12 Dec 2007) | 1 line

added tobias as fusion maintainer + tweaked spirit mainteners to joel de guzman and hartmut kaiser

........

r42001 | hljin | 2007-12-12 17:28:15 -0800 (Wed, 12 Dec 2007) | 1 line

GIL: fixed the Makefile along with a minor fix

........

r42005 | t_schwinger | 2007-12-13 02:32:11 -0800 (Thu, 13 Dec 2007) | 3 lines

fixes typo

........

r42006 | nesotto | 2007-12-13 04:06:21 -0800 (Thu, 13 Dec 2007) | 1 line

Marcin's improved version of erase_if + minor indentation tweaks

........

r42007 | igaztanaga | 2007-12-13 08:49:58 -0800 (Thu, 13 Dec 2007) | 1 line

Solved warning when using -Wall

........

r42009 | dgregor | 2007-12-13 10:14:01 -0800 (Thu, 13 Dec 2007) | 1 line

Tweak e-mail that sends notes to maintainers

........

r42012 | johnmaddock | 2007-12-13 10:45:58 -0800 (Thu, 13 Dec 2007) | 5 lines

Fixes #1454.

Previous fix was incomplete, so added new tests, confirmed problem report, and added fixes.

All the tests now compile cleanly with g++ -pedantic -Wall -Wno-long-long (checked with gcc-4.4.1 and 3.4.4).

........

r42013 | dgregor | 2007-12-13 11:20:23 -0800 (Thu, 13 Dec 2007) | 1 line

Send information about broken platforms to platform maintainers and the Boost testing list

........

r42014 | dgregor | 2007-12-13 11:20:55 -0800 (Thu, 13 Dec 2007) | 1 line

Set up initial platform maintainers file

........

r42015 | dgregor | 2007-12-13 11:21:21 -0800 (Thu, 13 Dec 2007) | 1 line

Add instructions and license for the maintainers file

........

r42016 | dgregor | 2007-12-13 11:22:52 -0800 (Thu, 13 Dec 2007) | 1 line

Minor tweak

........

r42017 | dgregor | 2007-12-13 11:57:47 -0800 (Thu, 13 Dec 2007) | 1 line

Fix generated URL

........

r42018 | nesotto | 2007-12-13 12:00:22 -0800 (Thu, 13 Dec 2007) | 1 line

forgot to submit this too

........

r42020 | bgubenko | 2007-12-13 13:40:26 -0800 (Thu, 13 Dec 2007) | 1 line

some markup for gcc 3.4.2 on PA-RISC and gcc 3.4.6 on Linux ia64

........

r42023 | lbourdev | 2007-12-13 21:32:21 -0800 (Thu, 13 Dec 2007) | 3 lines

GIL: Fixed Intel compiler errors.

........

r42025 | johnmaddock | 2007-12-14 02:11:21 -0800 (Fri, 14 Dec 2007) | 1 line

Fix typos reported by Sebastian Pipping.

........

r42035 | johnmaddock | 2007-12-14 08:36:40 -0800 (Fri, 14 Dec 2007) | 1 line

Fix bad comments in test files.

........

r42047 | turkanis | 2007-12-14 11:30:07 -0800 (Fri, 14 Dec 2007) | 127 lines

Changed signature and specification of boost::iostreams::close(), and made corresponding changes throughout the iostreams library. New spec is:

template<typename T> void close(T& t);

Convenience function for closing a device; calls close(t, in) and close(t, out).

template<typename T> void close(T& t, openmode which);

template<typename T, typename Sink> void close(T& t, Sink& snk, openmode which);

These two functions should only be called by the library implementation or by advanced users. The openmode parameter must always equal in or out, never in | out.

There are three cases:

If T is not closable and which == out, calls boost::iostreams::flush

If T operates on a single sequence, and is NOT a dual-use filter:

If which == in and the mode of T is convertible to input but not to output, calls t.close() (or t.close(snk))

If which == out and the mode of T is not convertible to input or is convertible to input and to output, calls t.close() (or t.close(snk))

The effect of a. and b. is that for any T in this category, close() is called exactly once.

If T operates on two sequences or is a dual-use filter, calls t.close(which) (or t.close(snk, which))

If multiple operations that might throw must be called in the course of closing a filter or device, all of the operations are attempted and the first exception thrown by any of the operations is rethrown

The new test close_test.cpp contains 95 checks verifying that the operation behaves as sepcified.

This affects the following files:

chain.hpp close.hpp code_converter.hpp combine.hpp compose.hpp copy.hpp detail/adapter/basic_adapter.hpp [removed] detail/adapter/device_adapter.hpp [new] detail/adapter/direct_adapter.hpp detail/adapter/filter_adapter.hpp [new] detail/adapter/mode_adapter.hpp detail/broken_overload_resolution/stream_buffer.hpp detail/closer.hpp [removed] detail/config/limits.hpp detail/execute.hpp [new] detail/functional.hpp [new] detail/streambuf/direct_streambuf.hpp detail/streambuf/indirect_streambuf.hpp detail/streambuf/linked_streambuf.hpp detail/vc6/close.hpp device/null.hpp filter/aggregate.hpp filter/bzip2.hpp filter/gzip.hpp filter/line.hpp filter/newline.hpp filter/symmetric.hpp filter/test.hpp invert.hpp restrict.hpp tee.hpp example/finite_state_filter.hpp test/Jamfile.v2 test/close_test.cpp [new] test/code_converter_test.cpp test/execute_test.cpp [new] test/operation_sequence_test.cpp [new]

When exceptions are caught and ignored, we now use catch (...)

uniformly instead of catch (std::exception&). This affects the following files:

stream_buffer.hpp src/mapped_file.cpp

Unnecessary dependence on Boost.Range has been eliminated. This

affects the following files:

detail/is_iterator_range.hpp detail/resolve.hpp traits.hpp test/Jamfile.v2 test/filtering_stream_test.cpp test/offset_test.cpp test/seek_test.hpp test/seekable_filter_test.cpp test/sequence_test.cpp [new] test/wide_stream_test.cpp

There are several fixes to the documentation. This affects the

following files:

doc/classes/symmetric_filter.html doc/guide/concepts.html doc/guide/modes.html doc/tutorial/container_device.html [serious error in algorithm] doc/tutorial/dictionary_filters.html [unused member variable] doc/tutorial/multichar_filters.html

Other changes include:

stream.hpp [missing include directive] example/container_device.hpp [serious error in algorithm] example/container_device_example.cpp [outdated naming] example/container_sink_example.cpp [outdated naming] example/container_source_example.cpp [outdated naming] example/dictionary_filter.hpp [unused member variable] test/compose_test.cpp [added comments] test/example_test.cpp [reformatted]

........

r42053 | anthonyw | 2007-12-14 13:47:10 -0800 (Fri, 14 Dec 2007) | 1 line

updated explicit failures for thread library

........

r42064 | bgubenko | 2007-12-14 19:42:49 -0800 (Fri, 14 Dec 2007) | 1 line

don't use identifires R1 and R2: some HP-UX headers define them as macros

........

r42065 | bgubenko | 2007-12-14 20:16:05 -0800 (Fri, 14 Dec 2007) | 1 line

don't use identifires R1 and R2: some HP-UX headers define them as macros

........