Boost C++ Libraries: Ticket #1464: boost_range_array unused in several array_size() functions

status changed

Thorsten Ottosen — Mon, 03 Dec 2007 09:02:43 GMT

status new → assigned

Please submit a patch

Thanks

-Thorsten

Thorsten Ottosen — Tue, 04 Dec 2007 14:48:11 GMT

I don't really no how to silence this warning, so I'd really appreciate a patch.

Thanks

-Thorsten

Thorsten Ottosen — Thu, 07 Feb 2008 14:40:33 GMT

I have now added a test that run for normal compilers. Neither vc8 nor gcc gives me any warnings. What compiler are you getting warnings with?

-Thorsten

sparent@… — Thu, 07 Feb 2008 20:31:13 GMT

gcc with -Wunused or -Wall (you can ask Mat Marcus for the bjam file if you would like) - our teams compile with all warnings on and warnings as errors. Here is the patch.

Sean

p4 diff 'boost_libraries/boost/range/detail/implementation_help.hpp#3'

boost_libraries/boost/range/detail/implementation_help.hpp#3 - /Users/sparent/development/projects/boost_libraries/boost/range/detail/implementation_help.hpp

112a113,120

/*

ADOBE (sparent@…) 1464 : Using unused parameter to silence warnings.

*/ template <typename T> inline void adobe_boost_range_size_unused(const T&) { } /*

END ADOBE

*/

116a125,131

/*

ADOBE (sparent@…) 1464 : Using unused parameter to silence warnings.

*/

adobe_boost_range_size_unused(boost_range_array);

/*

END ADOBE

*/

122a138,144

/*

ADOBE (sparent@…) 1464 : Using unused parameter to silence warnings.

*/

adobe_boost_range_size_unused(boost_range_array);

/*

END ADOBE

*/

128a151,157

/*

ADOBE (sparent@…) 1464 : Using unused parameter to silence warnings.

*/

adobe_boost_range_size_unused(boost_range_array);

/*

END ADOBE

*/

134a164,170

/*

ADOBE (sparent@…) 1464 : Using unused parameter to silence warnings.

*/

adobe_boost_range_size_unused(boost_range_array);

/*

END ADOBE

*/

sparent@… — Thu, 07 Feb 2008 20:33:48 GMT

Sorry - wiki ate that...

p4 diff '//boost_libraries/boost/range/detail/implementation_help.hpp#3'
==== //boost_libraries/boost/range/detail/implementation_help.hpp#3 - /Users/sparent/development/projects/boost_libraries/boost/range/detail/implementation_help.hpp ====
112a113,120
>         /*
>         	ADOBE (sparent@adobe.com) 1464 : Using unused parameter to silence warnings.
>         */
>         template <typename T>
>         inline void adobe_boost_range_size_unused(const T&) { }
>         /*
>         	END ADOBE
>         */
116a125,131
>         /*
>         	ADOBE (sparent@adobe.com) 1464 : Using unused parameter to silence warnings.
>         */
>         	adobe_boost_range_size_unused(boost_range_array);
>         /*
>         	END ADOBE
>         */
122a138,144
>         /*
>         	ADOBE (sparent@adobe.com) 1464 : Using unused parameter to silence warnings.
>         */
>         	adobe_boost_range_size_unused(boost_range_array);
>         /*
>         	END ADOBE
>         */
128a151,157
>         /*
>         	ADOBE (sparent@adobe.com) 1464 : Using unused parameter to silence warnings.
>         */
>         	adobe_boost_range_size_unused(boost_range_array);
>         /*
>         	END ADOBE
>         */
134a164,170
>         /*
>         	ADOBE (sparent@adobe.com) 1464 : Using unused parameter to silence warnings.
>         */
>         	adobe_boost_range_size_unused(boost_range_array);
>         /*
>         	END ADOBE
>         */

status changed; resolution set

Thorsten Ottosen — Fri, 08 Feb 2008 10:00:09 GMT

status assigned → closed
resolution → fixed

Fix in trunk.