https://svn.boost.org/trac10/ticket/1471 <p> Hi, </p> <p> When using Boost.Regex (<a class="changeset" href="https://svn.boost.org/trac10/changeset/41287" title="Fix search for Boost.Build so that it only finds the approved version.">r41287</a>) with MSVC8 SP1 and a non-default STL (STLport v5.1.4), I have VC8's usual warnings about the use of the "unsafe" CRT functions <code>strcat</code>/<code>strcpy</code>.<br /> AFAICT everything is there to avoid those warnings (i.e. to have Boost.Regex use <code>strcat_s</code>/<code>strcpy_s</code> instead)... it's just not applied in this particular case. </p> <p> One single preprocessor test in <code>boost/regex/v4/regex_workaround.hpp</code> controls two distinct things, which I think should be controlled by two separate tests. I suggest applying the attached patch (in <code>trunk/</code>), which splits that test in two: </p> <ul><li>first test (unchanged): <ul><li>if using VC8+ and the default Dinkumware STL: use custom <code>copy</code>/<code>equal</code> </li><li>otherwise: use STL <code>copy</code>/<code>equal</code> </li></ul></li><li>second test (new): <ul><li>if using VC8+ and the "secure" CRT: use CRT <code>strcat_s</code>/<code>strcpy_s</code> </li><li>otherwise: use Boost.Regex's custom <code>strcat_s</code>/<code>strcpy_s</code> </li></ul></li></ul><p> This way, <code>strcat_s</code>/<code>strcpy_s</code> get used when available, even if the first test is false (when not using Dinkumware STL).<br /> That patch has worked for me on both VC8 (SP1) and VC9 (beta 2). </p> <p> Cheers, Francois </p> en-us /htdocs/site/boost.png https://svn.boost.org/trac10/ticket/1471 Trac 1.4.3 Francois Barel Thu, 22 Nov 2007 17:47:09 GMT https://svn.boost.org/trac10/ticket/1471 https://svn.boost.org/trac10/ticket/1471 <ul> <li><strong>attachment</strong> → <span class="trac-field-new">BRL-warnings.diff</span> </li> </ul> Ticket John Maddock Tue, 11 Dec 2007 17:28:15 GMT https://svn.boost.org/trac10/ticket/1471#comment:1 https://svn.boost.org/trac10/ticket/1471#comment:1 <ul> <li><strong>status</strong> <span class="trac-field-old">new</span> → <span class="trac-field-new">closed</span> </li> <li><strong>resolution</strong> → <span class="trac-field-new">fixed</span> </li> </ul> <p> (In <a class="changeset" href="https://svn.boost.org/trac10/changeset/41973" title="Fixes #1471.">[41973]</a>) Fixes <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/1471" title="#1471: Patches: Boost.Regex: Warnings about strcat/strcpy on VC8+STLport (closed: fixed)">#1471</a>. </p> Ticket Eric Niebler Tue, 11 Dec 2007 22:00:09 GMT