Boost C++ Libraries: Ticket #1480: Boost:::Spirit bug in tree_to_xml.ipp

attachment set

anonymous — Wed, 28 Nov 2007 08:24:42 GMT

attachment → tree_to_xml.ipp

component changed; owner set

Marshall Clow — Wed, 28 Nov 2007 16:06:10 GMT

owner set to Joel de Guzman
component None → spirit

Joel de Guzman — Wed, 28 Nov 2007 16:34:18 GMT

The test above seems MS specific. Is this just a problem for MS? Can you write the code to be cross platform so I can add it to the test suite?

owner changed

Joel de Guzman — Wed, 28 Nov 2007 17:07:46 GMT

owner changed from Joel de Guzman to Hartmut Kaiser

rkudiyarov@… — Thu, 29 Nov 2007 10:15:00 GMT

Problem is not in test case, I suppose that it is in specialization template string_lit by wchar_t. Method static std::wstring get(char const* source = "") should have line
result.get()[len] = '\0';
after memory allocation by new, because constructor of string, which returned, evaluate incorrect size;

static std::wstring get(char const* source = "") {

typedef std::ctype<wchar_t> ctype_t;

using namespace std; some systems have size_t in ns std size_t len = strlen(source); std::auto_ptr<wchar_t> result (new wchar_t[len+1]); std::use_facet<ctype_t>(std::locale())

.widen(source, source + len, result.get());

return result.get();

}

But code with using tree_to_xml dont compile if not fix constructors of following classes: document, comment, text, node, element.

I attached correct file(tree_to_xml.ipp) in my report above. -- Best Regards, Kudiyarov Roman.

Joel de Guzman — Thu, 29 Nov 2007 11:40:54 GMT

Well, I'll still need a test case that is cross platform. Also, the fix you sent does not compile on gcc.

status changed; resolution set

Hartmut Kaiser — Thu, 29 Nov 2007 14:28:54 GMT

status new → closed
resolution → fixed

This is fixed now. The provided patch has been applied and a test has been added verifying everything is ok. I still need to merge this patches into the 1.35 release branch, though.