Boost C++ Libraries: Ticket #1507: [variant] C4512 warnings from VC8.0

attachment set

Sat, 08 Dec 2007 00:42:36 GMT

attachment → variant.patch

Fri, 21 Mar 2008 22:22:54 GMT

Running the variant regression tests on VC9 with warning level 4 produces a number of warnings in addition to the above:

boost/variant/variant.hpp(532) : warning C4512: 'boost::detail::variant::direct_assigner<T>' : assignment operator could not be generated
boost/variant/variant.hpp(695) : warning C4512: 'boost::detail::variant::swap_with<Variant>' : assignment operator could not be generated
boost/variant/variant.hpp(751) : warning C4512: 'boost::detail::variant::comparer<Variant,Comp>' : assignment operator could not be generated
boost/variant/detail/variant_io.hpp(67) : warning C4512: 'boost::detail::variant::printer<OStream>' : assignment operator could not be generated
boost/variant/detail/apply_visitor_binary.hpp(66) : warning C4512: 'boost::detail::variant::apply_visitor_binary_invoke<Visitor,Value1>' : assignment operator could not be generated
boost/variant/detail/apply_visitor_binary.hpp(103) : warning C4512: 'boost::detail::variant::apply_visitor_binary_unwrap<Visitor,Visitable2>' : assignment operator could not be generated

Theres also an 'unreferenced parameter' warning:

boost/variant/variant.hpp(289) : warning C4100: 'operand' : unreferenced formal parameter

attachment set

Fri, 21 Mar 2008 22:24:05 GMT

attachment → variant2.patch

Silence 4512 warnings on VC9

Mon, 05 May 2008 14:14:49 GMT

When building in release mode, VC8/9 also produce some unreachable code warnings:

boost\variant\detail\visitation_impl.hpp(205) : warning C4702: unreachable code
boost\variant\detail\visitation_impl.hpp(180) : warning C4702: unreachable code
boost\variant\detail\visitation_impl.hpp(252) : warning C4702: unreachable code
boost\variant\detail\visitation_impl.hpp(280) : warning C4702: unreachable code

Attached is a patch for visitation_impl.hpp that uses a pragma to silence these.

attachment set

Mon, 05 May 2008 14:15:03 GMT

attachment → visitation_impl.patch

attachment set

Sat, 30 May 2009 16:21:16 GMT

attachment → variant_300509.diff

milestone changed

Sat, 30 May 2009 16:25:25 GMT

milestone To Be Determined → Boost 1.40.0

It would be nice to have at least the 'unreachable code' and 'unreferenced parameter' warnings fixed in 1.40 (the unreferenced parameter warning in particular causes a lot of noise of VC9/10).

The 'assignment operator could not be generated' warnings are less important (i've taken to switching it off globally anyway).

Tue, 10 Nov 2009 13:12:27 GMT

A bunch of these have been fixed in [57501].

milestone changed

Tue, 10 Nov 2009 15:43:51 GMT

milestone Boost 1.40.0 → Boost 1.42.0

Attached an updated patch based on running the current code in VC9.

attachment set

Tue, 10 Nov 2009 15:44:23 GMT

attachment → variant101109.patch

Tue, 10 Nov 2009 15:47:10 GMT

The regression tests also cause a bunch of "possible loss of data" warnings that i haven't had a chance to look at. Build log attached if anyone is interested.

attachment set

Tue, 10 Nov 2009 15:47:41 GMT

attachment → variant.log

Wed, 11 Nov 2009 16:48:52 GMT

There is also some

"warning C4535: calling _set_se_translator() requires /EHa "

warnings. As mentioned in the post @ http://old.nabble.com/Re%3A-Official-warnings-policy--p26288257.html, these can be fixed by setting the asynch-exceptions option in the variant jamfile.

attachment set

Wed, 11 Nov 2009 16:49:24 GMT

attachment → variantjam.diff

anonymous — Thu, 12 Nov 2009 08:33:44 GMT

Replying to Richard Webb <richard.webb@…>:

There is also some

"warning C4535: calling _set_se_translator() requires /EHa "

warnings. As mentioned in the post @ http://old.nabble.com/Re%3A-Official-warnings-policy--p26288257.html, these can be fixed by setting the asynch-exceptions option in the variant jamfile.

The right fix should be:

project

: requirements

<source>/boost/testminimal

;

anonymous — Fri, 13 Nov 2009 10:08:47 GMT

Patches are now in Trunk, leaving open till they're in the release branch.

John.

status changed; resolution set

Steven Watanabe — Thu, 10 Jun 2010 15:32:19 GMT

status new → closed
resolution → fixed

(In [62742]) Merge variant from the trunk. Fixes #1507