Boost C++ Libraries: Ticket #1527: [program_options] Second (and subsequent) lines in tabbed text not aligned correctly

attachment set

s.ochsenknecht@… — Sun, 08 Nov 2009 10:25:17 GMT

attachment → ticket1527.patch

testcase

s.ochsenknecht@… — Sun, 08 Nov 2009 10:27:36 GMT

I cannot reproduce this with current trunk. I think the behaviour is correct. I get following output of the mentioned testcase:

  --list arg            a list:
                          item1, item2, item3, item4, item5, item6, item7,
                          item8, item9, item10, item11, item12, item13, item14,
                          item15, item16, item17, item18

I attached an enhancement for the test cases which checks the user case.

Please comment. Thanks.

status changed; resolution set

Vladimir Prus — Mon, 09 Nov 2009 15:57:52 GMT

status new → closed
resolution → fixed

(In [57515]) Test for \t-alignment of options descriptions.

Fixes #1527. Patch from Sascha Ochsenknecht.

Vladimir Prus — Mon, 09 Nov 2009 16:01:12 GMT

Sascha, I have applied the patch, thanks!

BTW, was there a specific reason you changed std::string to just string in a couple of places? Not that it matters much.

s.ochsenknecht@… — Mon, 09 Nov 2009 16:15:19 GMT

The source already had a "using namespace std;" and at some places were string's defined without "std::". So, I just wanted the source consistent without any redundancy.

Thanks, Sascha

status, version, milestone changed; resolution deleted

Chard — Mon, 30 Nov 2009 12:37:14 GMT

status closed → reopened
version Boost 1.34.1 → Boost 1.41.0
resolution fixed
milestone Boost 1.36.0 → Boost 1.42.0

Hi Volodya,

The original issue is valid and still present.

The responding poster has not actually copied the OP's code exactly.

There should be six spaces between the newline (\n) and tab (\t). The patched test code only uses two. This affects the spacing enough to make it output correctly.

Find attached a patch for the test file (as it appears on the trunk), which does cause the failure, and also a patch with the fix, which is a simple one-liner.

attachment set

Chard — Mon, 30 Nov 2009 12:38:11 GMT

attachment → options_description_test.patch

patch for test

attachment set

Chard — Mon, 30 Nov 2009 12:38:48 GMT

attachment → options_description.patch

patch for #1527

Sascha Ochsenknecht — Mon, 30 Nov 2009 13:38:03 GMT

Hi,

I just checked in the patch on trunk. It looks ok for me. I leave the Ticket open until Volodya reviewed it.

Sorry for confusion!

Thanks,

Sascha

status changed; resolution set

Vladimir Prus — Mon, 30 Nov 2009 14:01:57 GMT

status reopened → closed
resolution → fixed

Seems ok to me. I'm closing this issue. Thanks for the followup, Chard!