Boost C++ Libraries: Ticket #1537: no value given in 'mysql_password ='

attachment set

s.ochsenknecht@… — Tue, 10 Nov 2009 09:17:41 GMT

attachment → ticket1537.patch

possible patch

cc set

s.ochsenknecht@… — Tue, 10 Nov 2009 09:22:48 GMT

cc s.ochsenknecht@… added

I attached a patch which allows these empty values in config files. I simply removed the exception and enhanced one test case.

But, I can not survey the impact and possible side effects. And do we really want this behavior? At least the tests seam to work fine.

Please comment.

Sascha

Sascha Ochsenknecht — Fri, 20 Nov 2009 16:52:11 GMT

I applied the patch.

With one small modification. Empty values are ignored and nothing is stored. I think it makes sense since an empty string can not be converted to every possible value type, e.g. integer options.

Cheers

Sascha

status changed; resolution set

Sascha Ochsenknecht — Fri, 20 Nov 2009 16:53:11 GMT

status new → closed
resolution → fixed

(In [57819]) allow empty values in config file, Fixes #1537

status changed; resolution deleted

olafvdspek@… — Fri, 20 Nov 2009 16:57:12 GMT

status closed → reopened
resolution fixed

I don't think that's a good idea. There's a difference between an empty value and no value.

Vladimir Prus — Fri, 20 Nov 2009 17:47:16 GMT

I'd agree. Ignoring bits of config file seems a potentially confusing behaviour.

Sascha Ochsenknecht — Fri, 20 Nov 2009 18:10:04 GMT

Ok, another proposal would be to store an empty value for string type values (also for collection of strings) and throwing a validation error for e.g. integer types: "invalid option value "

This is probably better than storing a default constructed value, which could be undefined. Or in other words, what is an empty integer? undefined or invalid (I would prefer invalid -> exception)?

Please comment.

olafvdspek@… — Fri, 20 Nov 2009 18:22:46 GMT

Invalid

status changed; resolution set

Sascha Ochsenknecht — Sat, 21 Nov 2009 07:59:43 GMT

status reopened → closed
resolution → fixed

(In [57829]) store empty values from config file, Fixes #1537