Boost C++ Libraries: Ticket #1541: [parameter] Patch for missing includes

attachment set

Thu, 27 Dec 2007 14:45:17 GMT

attachment → parameter.patch

attachment set

Sat, 29 Dec 2007 13:23:54 GMT

attachment → boost.parameter.diff

Another patch

Sat, 29 Dec 2007 13:30:25 GMT

I added another patch which fixes even more missing include statements.

Since I got also many warnings about missing initialisations in python.hpp I added some zeros together with comments as found in another header file:

boost/parameter/python.hpp:66: warning: deprecated conversion from string constant to 'char*' boost/parameter/python.hpp:66: warning: missing initializer for member '_typeobject::tp_traverse' boost/parameter/python.hpp:66: warning: missing initializer for member '_typeobject::tp_clear' ...

All, except the first warning, are now fixed as well.

Now I get only one complain: boost/parameter/aux_/overloads.hpp:64: error: 'BOOST_PP_ENUM_PARAMS' has not been declared But since this is a private header file this is OK.

owner, status, severity, milestone changed

Markus Schöpflin — Wed, 02 Jan 2008 11:47:19 GMT

owner changed from Daniel Wallin to Markus Schöpflin
status new → assigned
severity Showstopper → Problem
milestone To Be Determined → Boost 1.36.0

To clear the test errors I have applied the first patch. I will leave the second patch alone as it is not critical, the library maintainers should decide what to do with it.

owner, status changed

Markus Schöpflin — Wed, 02 Jan 2008 11:48:18 GMT

owner changed from Markus Schöpflin to Daniel Wallin
status assigned → new

Oops, didn't want to modify the holder...

status changed; resolution set

Marshall Clow — Sat, 12 Jun 2010 17:42:29 GMT

status new → closed
resolution → fixed

Since the parameter library is no longer failing its' tests, I'm guessing that this patch is no longer necessary.

If I'm wrong, please reopen this ticket.

status changed; cc set; resolution deleted

Mon, 14 Jun 2010 11:37:03 GMT

cc jensseidel@… added
status closed → reopened
resolution fixed

Your guess is wrong. The file parameter/aux_/default.hpp is still unpatched and misses a #include <boost/detail/workaround.hpp> but uses BOOST_WORKAROUND. Also one or two other files are unpatched.

Is it really so hard for you to apply a one line patch or to check whether it is still required?

status changed; resolution set

Mon, 14 Jun 2010 11:47:56 GMT

status reopened → closed
resolution → fixed

Replying to Jens Seidel <jensseidel@…>:

Your guess is wrong. The file parameter/aux_/default.hpp is still unpatched and misses a #include <boost/detail/workaround.hpp> but uses BOOST_WORKAROUND. Also one or two other files are unpatched.

Oops, I'm wrong. I don't have any longer a copy of the Boost repository (why should I when all patches are ignored?) and used the web frontend. It seems I looked partly in too old revisions.

parameter/aux_/python/invoker_iterate.hpp seems to still miss a include of boost/preprocessor/iteration/iterate.hpp for BOOST_PP_ITERATION_FLAGS but I'm not willing to test it now.

I close this bug again ... (the last sentence of the last comments still applies, though).