Boost C++ Libraries: Ticket #1563: MS releases TR1 support Beta

status changed; cc set

John Maddock — Wed, 09 Jan 2008 17:20:40 GMT

cc jrp@… added
status new → assigned

I'll look into this, in the mean time, if you can see any means of detecting when VC9 TR1 update has been installed, that would be a big help, John.

John Maddock — Wed, 09 Jan 2008 17:36:53 GMT

Looking at this further, it appears that the version of VC9 I have doesn't support this beta, so I can't install it :-(

The documentation mentions the define _HAS_TR1, can you check to see if this gets defined to a non zero value after including <utility> or not?

Many thanks, John.

Wed, 09 Jan 2008 22:47:16 GMT

THeres a

 #if !defined(_HAS_TR1)
  #define _HAS_TR1	1	/* enable TR1 extensions */
 #endif /* !defined(_HAS_TR1) */

in yvals.h, which is included as a result of including <utility> (amongst other things).

I tried changing the VC bit of tr1\detail\config.hpp to

#if _HAS_TR1
#  define BOOST_HAS_TR1_ARRAY
#  define BOOST_HAS_TR1_REFERENCE_WRAPPER
#  define BOOST_HAS_TR1_RESULT_OF
#  define BOOST_HAS_TR1_MEM_FN
#  define BOOST_HAS_TR1_BIND
#  define BOOST_HAS_TR1_FUNCTION
#  define BOOST_HAS_TR1_HASH
#  define BOOST_HAS_TR1_SHARED_PTR
#  define BOOST_HAS_TR1_RANDOM
#  define BOOST_HAS_TR1_REGEX
#  define BOOST_HAS_TR1_TUPLE
#  define BOOST_HAS_TR1_TYPE_TRAITS
#  define BOOST_HAS_TR1_UTILITY
#  define BOOST_HAS_TR1_UNORDERED_MAP
#  define BOOST_HAS_TR1_UNORDERED_SET
#else
#  define BOOST_HAS_TR1_HASH
#endif

And successfully called the MS versions of bind and shared_ptr (with the same code on VC8 still calling the Boost versions.) I havent tried any other libs yet.

John Maddock — Thu, 10 Jan 2008 12:03:59 GMT

Can you try building the TR1 tests with this change?

And compare the results to the effect with _HAS_TR1=0 defined?

Thanks!

John.

attachment set

Thu, 10 Jan 2008 12:56:38 GMT

attachment → tr1.zip

TR1 test results

attachment set

Thu, 10 Jan 2008 12:57:28 GMT

attachment → notr1.zip

TR1 test results with _HAS_TR1=0

Thu, 10 Jan 2008 13:09:42 GMT

Running the tests with _HAS_TR1=1 results in a lot of test failures, with some seemingly down to missing typedefs in the MS libs. e.g.

test_bind.cpp(33) : error C2039: 'result_type' : is not a member of 'std::tr1::_Bind<_Ret,_BindN>'
E:\BoostSVN\boost/regex/concepts.hpp(560) : error C2039: 'size_type' : is not a member of 'std::tr1::basic_regex<_Elem>'
test_hash.cpp(22) : error C2039: 'argument_type' : is not a member of 'std::tr1::hash<std::string>'

The docs that ship with the beta say that bind has some problems, but i don't know about the others.

Adding a <define>_HAS_TR1=0 to the test jamfile and then re-running the test gives the same results you get now without the beta (the MS version of hash gets included regardless of _HAS_TR1, so that still fails).

Building the current Trunk code with the beta results in loads of 'multiple declaration' errors, and my change removes all those.

See attached logs for more info

status changed; resolution set

John Maddock — Mon, 14 Jan 2008 16:22:35 GMT

status assigned → closed
resolution → fixed

I've just committed your suggested patch: on the basis that VC9 + the feature pack will be unusable without it!

However, if there are any regressions in the release branch it'll just get yanked out I'm afraid :-(

Regards, John.