Boost C++ Libraries: Ticket #1618: Warnings need supressing

Tue, 05 Feb 2008 18:03:02 GMT

Have you tried testing this with 1.35 / Trunk?

A lot of the warnings have already been fixed - see #1523 for an example.

Sat, 09 Feb 2008 18:20:49 GMT

Running the iostreams tests with VC9 and warning level 4 results in a few unreferenced parameter warnings:

\boost/iostreams/filter/newline.hpp(401) : warning C4100: 'which' : unreferenced formal parameter
\boost/iostreams/filter/newline.hpp(214) : warning C4100: 'which' : unreferenced formal parameter
\boost/iostreams/filter/symmetric.hpp(155) : warning C4100: 'which' : unreferenced formal parameter

Running the tests with code analysis enabled results in loads of 'sizeof usage' warnings:

boost\iostreams\traits.hpp(49) : warning C6334: sizeof operator applied to an expression with an operator might yield unexpected results

(which actually results from the usage of sizeof in the macro in bool_trait_def.hpp) I dont think it's really a problem, but it creates a lot of noise.

attachment set

Sat, 09 Feb 2008 18:41:36 GMT

attachment → ios4a.zip

log of iostreams tests built with vc9/w4/code analysis

status changed

Jonathan Turkanis — Mon, 26 May 2008 20:00:48 GMT

status new → assigned

I believe the warnings 4512, 4127, and 4100 have all been addressed previously.

I am unable to reproduce 6334, either because my versions of VC (8.0 pro and 9.0 express) don't support code analysis, or because I am too stupid to figure out how to turn it on.

I have attempted to fix the problem in [45788] by disabling warning 6334 around invocations of BOOST_IOSTREAMS_BOOL_TRAIT_DEF in traits.hpp and detail/is_iterator_range.hpp.

Please let me know if this resolves the issue. If not, please generate another log of VC output using the current trunk.

Tue, 27 May 2008 20:02:08 GMT

Thats fixed some of the 6334s. but there are some left (from other BOOST_IOSTREAMS_BOOL_TRAIT_DEF uses, and from BOOST_SELECT_BY_SIZE).

Moving the 'pragma warning(pop)' further down the file silences those.

attachment set

Tue, 27 May 2008 20:03:39 GMT

attachment → traits.diff

attachment set

Tue, 27 May 2008 20:06:51 GMT

attachment → iostreams.zip

Jonathan Turkanis — Tue, 27 May 2008 23:59:52 GMT

Okay, I've moved the code suppressing 6334 into detail/config/disable_warnings.hpp and included that file in traits.hpp and is_iterator_range.hpp. This should cover all the code in those two files (see [45843])

Thu, 29 May 2008 22:13:04 GMT

Ok, that seems to have got them all now :)

status changed; resolution set

Jonathan Turkanis — Thu, 29 May 2008 22:45:15 GMT

status assigned → closed
resolution → fixed

status changed; resolution deleted

Sat, 14 Jun 2008 11:43:07 GMT

status closed → reopened
resolution fixed

Looking at the test results (e.g. http://tinyurl.com/5jawvj), i notice that there is now an extra warning on VC7.1 because C6334 only exists on VC8+:

boost\iostreams\detail\config\disable_warnings.hpp(19) : warning C4616: #pragma warning : warning number '6334' out of range, must be between '4001' and '4999'

This can be fixed by only disabling 6334 on visual studio 8 or newer. Sorry for not thinking of this earlier.

Jonathan Turkanis — Sat, 14 Jun 2008 18:27:08 GMT

(In [46394]) limitted disabling of compiler warning 6334 to VC8.0+ (see #1618)

status changed; resolution set

Jonathan Turkanis — Sat, 14 Jun 2008 18:31:23 GMT

status reopened → closed
resolution → fixed

That's funny. I remember planning to test "pragma warning(disable:9999)" on VC8.0 to see if it produced an "unknown warning" warning -- in fact, I thought I had done so.

I've now disabled the warning only if BOOST_WORKAROUND(BOOST_MSVC, >= 1400) (See #1618). I'm assuming this works, and re-closing the ticket.

Thanks for all your help, Richard.