Boost C++ Libraries: Ticket #1714: crash due to new shared_from_this code

cc set

Peter Dimov — Tue, 25 Mar 2008 15:12:23 GMT

cc Peter Dimov added

This is likely caused by the fact that _internal_accept_owner doesn't check whether _owned isn't already true. The following simpler test also crashes:

#include <boost/shared_ptr.hpp>
#include <boost/enable_shared_from_this.hpp>
struct X: public boost::enable_shared_from_this< X >
{
};
struct null_deleter
{
    void operator()( void const* ) const
    {
    }
};
int main()
{
    boost::shared_ptr<X> px( new X );
    boost::shared_ptr<X> px2( px.get(), null_deleter() );
}

attachment set

Dave Abrahams — Tue, 25 Mar 2008 15:46:33 GMT

attachment → enable_shared_from_this.patch

This appears to fix the bug but I have no idea if the logic is right.

Peter Dimov — Tue, 25 Mar 2008 15:48:44 GMT

I checked in a fix: [43856]

status changed; resolution set

Dave Abrahams — Tue, 25 Mar 2008 16:05:15 GMT

status new → closed
resolution → fixed

it works!