Boost C++ Libraries: Ticket #1715: gcc-4.3 doesn't compile polymorphic_(i)(o)archive.hpp

attachment set

Tue, 25 Mar 2008 19:47:04 GMT

attachment → build_log

Mon, 31 Mar 2008 11:02:56 GMT

I found the origin of the problem.

This piece of code

#if defined(BOOST_NO_INT64_T) \
    || (ULONG_MAX != 0xffffffff && ULONG_MAX == 18446744073709551615u) // 2**64 - 1
#   define BOOST_NO_INTRINSIC_INT64_T
#endif

doesn't work as expected, since ULONG_MAX is not defined at this place when g++-4.3.x is used.

The code should check if ULONG_MAX is available before using it.

The fact that ULONG_MAX is not defined is caused by the include file cleanup made for GCC-4.3. To bring ULONG_MAX back, just add

#include <climits>

to the list of include files.

A patch which does the suggestions above, and thus fixes the build with g++-4.3.x, is attached.

Best,

-- Maik

attachment set

Mon, 31 Mar 2008 11:03:51 GMT

attachment → serialization_gcc43.patch

fix build with GCC-4.3

status changed; resolution set

Robert Ramey — Mon, 31 Mar 2008 15:43:19 GMT

status new → closed
resolution → fixed

good call - fixed in trunk

Robert Ramey

status changed; resolution deleted

Mon, 31 Mar 2008 16:38:32 GMT

status closed → reopened
resolution fixed

Your code

#if defined(BOOST_NO_INT64_T)
    #if defined(ULONG_MAX)
        #if(ULONG_MAX != 0xffffffff && ULONG_MAX == 18446744073709551615u) // 2**64 - 1
            #define BOOST_NO_INTRINSIC_INT64_T
        #endif
    #else
        #define BOOST_NO_INTRINSIC_INT64_T
    #endif
#endif

doesn't work, since if BOOST_NO_INT64_T isn't defined ULONG_MAX isn't even considerd. I guess you want

#if defined(BOOST_NO_INT64_T)
    #define BOOST_NO_INTRINSIC_INT64_T
#else
    #if defined(ULONG_MAX)
        #if(ULONG_MAX != 0xffffffff && ULONG_MAX == 18446744073709551615u) // 2**64 - 1
            #define BOOST_NO_INTRINSIC_INT64_T
        #endif
    #else
        #define BOOST_NO_INTRINSIC_INT64_T
    #endif
#endif

but I prefer

#if defined(BOOST_NO_INT64_T)
    #define BOOST_NO_INTRINSIC_INT64_T
#else
    #if defined(ULONG_MAX)
        #if(ULONG_MAX != 0xffffffff && ULONG_MAX == 18446744073709551615u) // 2**64 - 1
            #define BOOST_NO_INTRINSIC_INT64_T
        #endif
    #else
        #error "ULONG_MAX is not defined"
    #endif
#endif

#if defined(BOOST_NO_INT64_T)
    #define BOOST_NO_INTRINSIC_INT64_T
#elif defined(ULONG_MAX)
    #if(ULONG_MAX != 0xffffffff && ULONG_MAX == 18446744073709551615u) // 2**64 - 1
        #define BOOST_NO_INTRINSIC_INT64_T
    #endif
#else
    #error "ULONG_MAX is not defined"
#endif

status changed; resolution set

Robert Ramey — Mon, 31 Mar 2008 16:48:47 GMT

status reopened → closed
resolution → fixed

OK - fixed again

Mon, 31 Mar 2008 16:55:53 GMT

Works!

Thank you for quickly responding,

-- Maik

patrick@… — Tue, 24 Jun 2008 18:07:48 GMT

I'm confused. Isn't the meaning of NO_INTRINSIC_INT64_T that there's no intrinsic 64 bit int, but isn't the long long an intrisic 64 bit type? Why does this get set? When I was first looking at it I though the test in polymorphic_(i/o)archive.hpp to decide whether to include the int64 templates was backwards, but now this tells me the test was right, but I didn't understand?

component, milestone changed

Essexiaerania — Sat, 10 Sep 2011 08:27:54 GMT

component serialization → Building Boost
milestone To Be Determined → Boost 1.48.0

what I was looking for, thanks