Boost C++ Libraries: Ticket #1740: date_time includes

anonymous — Thu, 10 Apr 2008 19:03:57 GMT

This is also breaking Asio, as Asio wants to include winsock, see: http://permalink.gmane.org/gmane.comp.lib.boost.devel/172990

Anteru — Thu, 10 Apr 2008 19:05:12 GMT

Forgot to set the name -- this comment is from me, Anteru

anonymous — Tue, 08 Jul 2008 15:09:09 GMT

This is a very serious bug for us as well as it completely breaks our entire project. It does not appear that any code which uses Windows.h is required to be inline or even public. We have yet to find a work around which allows us to build using 1.35 and have been stuck on 1.34.1.

A fix soon would be greatly appreciated.

attachment set

emilm@… — Sat, 11 Oct 2008 08:29:26 GMT

attachment → date_time.patch

emilm@… — Sat, 11 Oct 2008 08:29:43 GMT

Please find attached a patch to solve this issue and the test report of the library on the compiler I have at my disposal. I have taken precautions in order to ensure it will work on x64 Windows (please see comments related to the conversion between FILETIME and int64) and I see no reason it should have changed for other platforms, but only testing will tell.

status changed; resolution set

Andrey Semashev — Thu, 13 Nov 2008 18:11:37 GMT

status new → closed
resolution → fixed

status, version changed; keywords set; resolution deleted

anonymous — Mon, 17 Aug 2009 15:15:50 GMT

keywords windows.h date_time added
status closed → reopened
version Boost 1.35.0 → Boost 1.39.0
resolution fixed

If you do include windows.h anywhere in boost, you need the following two lines of code just above it:

#undef  WIN32_LEAN_AND_MEAN  // add this...
#define WIN32_LEAN_AND_MEAN  // ...and this
#include <windows.h>

Otherwise, if some other 3rd party lib includes <windows.h>, it will break the build unless the header files are in a very specific order, which is extremely tedious to maintain.

status changed; resolution set

anonymous — Fri, 25 Sep 2009 20:09:11 GMT

status reopened → closed
resolution → fixed

Replying to anonymous:

If you do include windows.h anywhere in boost, you need the following two lines of code just above it:
#undef  WIN32_LEAN_AND_MEAN  // add this...
#define WIN32_LEAN_AND_MEAN  // ...and this
#include <windows.h>
Otherwise, if some other 3rd party lib includes <windows.h>, it will break the build unless the header files are in a very specific order, which is extremely tedious to maintain.

First, Boost.DateTime no longer includes windows.h by default. You can explicitly enable it to include windows.h by defining BOOST_USE_WINDOWS_H.

Second, defining WIN32_LEAN_AND_MEAN will disable quite a few components in windows.h. Boost.DateTime is in no position to enforce this decision in its headers. If you want windows.h to behave like when WIN32_LEAN_AND_MEAN is defined, you should define it in your project, before including any headers.