Boost C++ Libraries: Ticket #1808: Trim middle

OlafvdSpek@… — Thu, 10 Apr 2008 13:14:50 GMT

I hate Trac! Anyway, my email address is OlafvdSpek@GMail.Com

olafvdspek@… — Wed, 16 Jun 2010 17:20:06 GMT

Pavol?

anonymous — Wed, 16 Jun 2010 17:23:32 GMT

Sorry for not responding. Generally I can offer you a deal: You code it and I can integrate it into the library. I agree that the function is useful. I would only suggest to call it compress_spaces.

anonymous — Wed, 16 Jun 2010 17:29:32 GMT

Sounds fair. What should the multi-line version be called?

Pavol Droba — Wed, 16 Jun 2010 18:07:46 GMT

Maybe the multi-line version is not realy necessary. You can replace it by two calls to the compress functions with different space specifications.

Also try to think, how to handle different line endings (<CR>,<LF>,<CR><LF>) If might be possible to define the compress function via means of find/replace framework. There is even one example in the library that does something similar.

Send me an email when you will have something to show at droba -at - topmail -dot- sk

olafvdspek@… — Thu, 05 Aug 2010 13:23:57 GMT

return ::boost::algorithm::find_format_all_copy(
	::boost::trim_copy(v),
	::boost::algorithm::token_finder(boost::is_space(),	::boost::algorithm::token_compress_on),
	::boost::algorithm::const_formatter(" "))

anonymous — Thu, 25 Nov 2010 17:46:08 GMT

Pavol?

milestone changed

anonymous — Thu, 30 Dec 2010 21:12:39 GMT

milestone Boost 1.36.0 → Boost 1.46.0

olafvdspek@… — Wed, 13 Apr 2011 17:23:28 GMT

Hi Pavol,

What's the status of this issue?

owner, component changed

Marshall Clow — Wed, 28 Dec 2011 18:51:28 GMT

owner changed from Pavol Droba to Marshall Clow
component string_algo → algorithm

Marshall Clow — Wed, 29 Feb 2012 20:27:43 GMT

Is there some reason that boost::algorithm::trim_all doesn't do what you want?

        //! Trim All
        /*!
            Remove all leading and trailing spaces from the input and
            compress all other spaces to a single character.

Wed, 29 Feb 2012 20:36:45 GMT

Hi Marshall,

trim_all is the response to this request. ;)

However, it's not quite right yet. It should compress all spaces to a single space, not a single character.

Marshall Clow — Wed, 29 Feb 2012 22:33:01 GMT

And trim_fill (blah, " ") doesn't do that?

        //! Trim Fill
        /*!
            Remove all leading and trailing spaces from the input and
            replace all every block of consecutive spaces with a fill string
            defined by user.

I'm not trying to be a pain here, just trying to understand.

Wed, 29 Feb 2012 23:53:14 GMT

Ah, yes, trim_fill was created to work around that problem. The original idea was for trim_all to do that from the start, without having to manually specify the 'fill' character/string.