Boost C++ Libraries: Ticket #1988: Boost.Config macros badly added.

Dean Michael Berris — Mon, 29 Nov 2010 02:40:51 GMT

Is this still an issue? Has this already been adressed and if not should this be broken up into smaller issues that can independently be addressed?

anonymous — Mon, 29 Nov 2010 12:20:36 GMT

Yes it still appears to be an issue, these macros weren't added correctly to Boost.Config.

I don't see how this can be broken up into smaller issues though sorry...

John.

PS if someone takes this on, they will need to take the changes through into the release branch as well.

Dean Michael Berris — Mon, 29 Nov 2010 12:48:23 GMT

I'll see if I can get patches out and tests run to see whether I can take this on. I'll give it some time tomorrow morning (PHT), I'll update as I run into issues or whether I have progress appropriately.

Marshall Clow — Tue, 26 Apr 2011 15:03:37 GMT

Dean - are you still going to do this?

Here's what a quick search turns up:

trunk marshall$ grep -r BOOST_NO_THREADEX *
boost/config/compiler/visualc.hpp:#  define BOOST_NO_THREADEX
libs/thread/src/win32/thread.cpp:#ifdef BOOST_NO_THREADEX
trunk marshall$ grep -r BOOST_NO_GETSYSTEMTIMEASFILETIME *
boost/config/compiler/visualc.hpp:#  define BOOST_NO_GETSYSTEMTIMEASFILETIME
boost/date_time/filetime_functions.hpp:#elif defined(BOOST_NO_GETSYSTEMTIMEASFILETIME)

If you don't have time, I can probably take care of this.

Dean Michael Berris — Tue, 26 Apr 2011 22:35:41 GMT

Nope, sorry about that -- please go ahead and take this one on. I shall punt this to you. :)

Marshall Clow — Wed, 27 Apr 2011 15:51:12 GMT

(In [71533]) Renamed BOOST_NO_THREADEX -> BOOST_HAS_THREADEX and BOOST_NO_GETSYSTEMTIMEASFILETIME --> BOOST_HAS_GETSYSTEMTIMEASFILETIME - Refs #1988

status changed; resolution set

Marshall Clow — Mon, 02 May 2011 20:56:55 GMT

status new → closed
resolution → fixed

(In [71676]) Merge fixes to release; Fixes #1988