Boost C++ Libraries: Ticket #2010: bas64 iterator improvement

Boost C++ Libraries: Ticket #2010: bas64 iterator improvement https://svn.boost.org/trac10/ticket/2010 <pre class="wiki"> Hello, > > Code that pads base64 output with '=' looks in > basic_text_oprimitive.ipp like following: > > std::size_t padding = 2 - count % 3; > if(padding > 1) > *oi = '='; > if(padding > 2) > *oi = '='; > > It will give the following transformations of a few simple strings: > > "012" -> "MDEy=" > "0123" -> "MDEyMw" > "01234" -> "MDEyMzQ" > "012345" -> "MDEyMzQ1=" > > Which violates the principle of the base 64 that the encoded output > length is multiple of 4 bytes. Right output for the samples above > should be: > > "012" -> "MDEy" > "0123" -> "MDEyMw==" > "01234" -> "MDEyMzQ=" > "012345" -> "MDEyMzQ1" > > > The problem with the code above is that the condition (padding > 2) > is never satisfied. I think that the proper code should look like > > std::size_t padding = 2 - count % 3; > if (padding < 2) { > *oi = '='; > if (padding > 0) > *oi = '='; > } </pre> en-us Boost C++ Libraries /htdocs/site/boost.png https://svn.boost.org/trac10/ticket/2010 Trac 1.4.3 Robert Ramey Sat, 14 Jun 2008 16:08:04 GMT status changed https://svn.boost.org/trac10/ticket/2010#comment:1 https://svn.boost.org/trac10/ticket/2010#comment:1 <ul> <li><strong>status</strong> <span class="trac-field-old">new</span> → <span class="trac-field-new">assigned</span> </li> </ul> Ticket Robert Ramey Thu, 11 Sep 2008 15:24:39 GMT status changed; resolution set https://svn.boost.org/trac10/ticket/2010#comment:2 https://svn.boost.org/trac10/ticket/2010#comment:2 <ul> <li><strong>status</strong> <span class="trac-field-old">assigned</span> → <span class="trac-field-new">closed</span> </li> <li><strong>resolution</strong> → <span class="trac-field-new">fixed</span> </li> </ul> <p> change checked into trunk </p> Ticket