Boost C++ Libraries: Ticket #2115: Avoid bad Apple macros

Marshall Clow — Mon, 14 Jul 2008 13:42:46 GMT

Just F-everyone's-I, here's a list of the macros defined in AssertMacros.h:

debug_string, check, ncheck, check_string, ncheck_string, check_noerr, check_noerr_string, verify, nverify, verify_string, nverify_string, verify_noerr, verify_noerr_string, verify_action, require, nrequire, require_action, nrequire_action, require_quiet, nrequire_quiet, require_action_quiet, nrequire_action_quiet, require_string, nrequire_string, requireaction_string, nrequireaction_string, require_noerr, require_noerr_action, require_noerr_quiet, require_noerr_action_quiet, require_noerr_string, require_noerr_action_string.

IMHO, the really nasty ones are: check, verify, require and check_error.

My suggestion is to #define ASSERTMACROS in the darwin Jamfile, and to add a warning to the docs.

Marshall Clow — Mon, 14 Jul 2008 13:44:24 GMT

The Wiki decided some of my text was formatting. The macro to define is "_ _ ASSERTMACROS _ _ " (w/o the spaces)

status changed

Beman Dawes — Sat, 11 Oct 2008 13:00:18 GMT

status new → assigned

Thu, 13 Nov 2008 20:39:12 GMT

Made changes to boost/detail/is_incrementable.hpp to get it to compile in the presence of the Apple check macro. Please see attached file.

attachment set

Thu, 13 Nov 2008 20:39:50 GMT

attachment → is_incrementable.hpp

is_incrementable.hpp patch

John Maddock — Fri, 14 Nov 2008 10:00:15 GMT

We've let this issue drop,

but... since we have the macro BOOST_PREVENT_MACRO_SUBSTITUTION to suppress this kind of unexpected macro substitution, maybe we should just go ahead and add all the Apple macros to the inspect program?

John.

Dave Abrahams — Fri, 14 Nov 2008 17:14:03 GMT

Perhaps sadly, I have to agree.

Marshall Clow — Fri, 20 Nov 2009 18:12:13 GMT

I have added the ability to find "check", "require", "verify" and "check_error" to the inspection program. It found almost 3000 files using these identifiers (2899, to be precise).

Cleaning this up is going to be a large task.

cc changed

Mateusz Loskot — Tue, 09 Mar 2010 23:27:54 GMT

cc mateusz@… added

status changed; resolution set

Beman Dawes — Mon, 30 May 2011 15:59:30 GMT

status assigned → closed
resolution → fixed

Closing inactive ticket

--Beman