Boost C++ Libraries: Ticket #2264: Warning C4244 in VS2005 build for PocketPC

status changed

Daniel James — Fri, 29 Aug 2008 14:19:01 GMT

status new → assigned

An explicit cast wouldn't be a good idea because it can hide potential problems. If that's the only solution, then I'd want to use a macro to only enable it when it's needed.

Please can you run the programs attached to the mail at http://lists.boost.org/Archives/boost/2005/04/83834.php, and attach the output to this ticket. And the output from libs/config/test/config_info.cpp in boost would also be helpful. That should at least give me an idea of the situation. Thanks.

attachment set

Tue, 02 Sep 2008 08:49:33 GMT

attachment → output1.txt

Output from test_float1.cpp

attachment set

Tue, 02 Sep 2008 08:50:02 GMT

attachment → output2.txt

Output from test_float2.cpp

Tue, 02 Sep 2008 08:53:05 GMT

It seems the platform does support float versions of math functions. I didn't run config_info.cpp, because my platform is a standard VS2005/PocketPC2003 project running on WM5.

Daniel James — Tue, 02 Sep 2008 10:10:59 GMT

I wanted to see the output of config_info so that I could see what macros the platform sets as I don't have access to it myself. But it seems that the best thing to do is always use the c99 functions for the Dinkumware libraries so I'll change it to do that.

Daniel James — Tue, 02 Sep 2008 10:31:28 GMT

(In [48529]) Always use c99 float function overloads on Dinkumware, as it doesn't always have the C++ overloads. Refs #2264.

Daniel James — Mon, 08 Sep 2008 21:06:18 GMT

(In [48674]) Reinstate the old choice of float functions on Dinkumware for all compilers other than Visual C++.

It turns out that Borland uses Dinkumware but doesn't have the C99 float overloads, so it only seems realistic to assume their existence on Visual C++. Refs #2264.

Daniel James — Thu, 11 Sep 2008 09:44:34 GMT

Okay, I think the current trunk gets it right, can you test it? If it works for you, I'll merge into release and close this ticket.

Thu, 11 Sep 2008 13:47:20 GMT

The code compiles without warning now. I think it is OK.

status changed; resolution set

Daniel James — Thu, 11 Sep 2008 18:28:52 GMT

status assigned → closed
resolution → fixed

(In [48739]) Always use c99 float function overloads when using Dinkumware with Visual C++, as it doesn't always have the C++ overloads. Fixes #2264.

Merged revisions 48529,48674 via svnmerge from https://svn.boost.org/svn/boost/trunk

........

r48529 | danieljames | 2008-09-02 11:31:26 +0100 (Tue, 02 Sep 2008) | 1 line

Always use c99 float function overloads on Dinkumware, as it doesn't always have the C++ overloads. Refs #2264.

........

r48674 | danieljames | 2008-09-08 22:06:16 +0100 (Mon, 08 Sep 2008) | 7 lines

Reinstate the old choice of float functions on Dinkumware for all compilers other than Visual C++.

It turns out that Borland uses Dinkumware but doesn't have the C99 float overloads, so it only seems realistic to assume their existence on Visual C++. Refs #2264.

........