Boost C++ Libraries: Ticket #2309: Lack of g++ symbol visibility support in Boost.Thread

attachment set

rbock@… — Tue, 09 Sep 2008 08:16:56 GMT

attachment → BoostThreads.cpp

Small sample, compile with g++ -fvisibility-hidden and link with the shared object instead of the static library

Jürgen Hunold — Wed, 10 Sep 2008 16:58:25 GMT

This is related to #2114. That issue contains a patch adding visibility support for most Boost Libraries.

attachment set

Tue, 09 Feb 2010 20:53:32 GMT

attachment → thread_interrupted.patch

created vs Boost v 1.42.0 to add visibility to boost::thread's exceptions

keywords, milestone changed; cc set

Tue, 09 Feb 2010 21:08:34 GMT

cc Bailey@… added
keywords thread thread_interrupted added
milestone Boost 1.37.0 → Boost 1.43.0

Description

thread_interrupted can't be caught when crossing shared object's boundaries when visibility is hidden.

Found In

Boost v1.40, v1.41, and 1.42

Recreating

Here is the setup:

MyCommon.so

this lib contains some basic classes, one of which (baseTRx) has a boost::thread.
this lib includes boost_system and boost_thread using the --whole-archive flag (linux) and equivalent for darwin and win -- this was done to minimize the number of files the customer would receive, among other reasons...

MyTRx.so

this lib contains a class derived from baseTRx (myTRx).
links to MyCommon

MyEXE

this contains main().
links to MyCommon
loads MyTRx at run time.
creates an instance of myTRx.
signals MyEXE (via interupt()) when its time to cleanly shut down

Using GCC 4.2 w/ -fvisibility=hidden, thread_interrupted isn't being caught in myTRx since it's being thrown from a different so with hidden visibility.

Possible Fixes

These are the options as I see them:

push, then set visibility to default in the BOOST_ABI_PREFIX. Then pop in the BOOST_ABI_SUFFIX.
add class decorators to modify visibility of exceptions

I provided a patch (thread_interrupted.patch ) for the second option. I am using this patch in a production environment.

Similar/possibly Related Defects

This is similar to the following defects:

#2114 Patch for export symbols from shared library

owner, status, milestone changed

viboes — Sun, 04 Dec 2011 10:38:19 GMT

owner changed from Anthony Williams to viboes
status new → assigned
milestone Boost 1.43.0 → Boost 1.49.0

Committed in trunk At revision: 75799

status changed; resolution set

viboes — Sat, 07 Jan 2012 21:48:29 GMT

status assigned → closed
resolution → fixed

Committed in release at #76291