Boost C++ Libraries: Ticket #2345: [mpl] Patch to improve support for CodeGear C++Builder 2009

attachment set

Nicola Musatti — Thu, 18 Sep 2008 22:26:33 GMT

attachment → boost_mpl.patch

Nicola Musatti — Mon, 29 Sep 2008 22:19:42 GMT

Although I have commit privileges I'd rather have this patch reviewed before applying it myself (aleksey?)

status changed

Aleksey Gurtovoy — Wed, 08 Oct 2008 02:33:25 GMT

status new → assigned

Aleksey Gurtovoy — Wed, 08 Oct 2008 02:50:24 GMT

Overall, it looks good. A couple of questions:

In "assert.hpp", why

-#if BOOST_WORKAROUND(__BORLANDC__, >= 0x560) && BOOST_WORKAROUND(__BORLANDC__, < 0x600) \
+#if BOOST_WORKAROUND(__BORLANDC__, BOOST_TESTED_AT(0x610)) \

vs.

-#if BOOST_WORKAROUND(__BORLANDC__, >= 0x560) && BOOST_WORKAROUND(__BORLANDC__, < 0x600) \
+#if BOOST_WORKAROUND(__BORLANDC__, >= 0x560) && BOOST_WORKAROUND(__BORLANDC__, BOOST_TESTED_AT(0x610)) \

In "quote.hpp", why

-#if defined(BOOST_MPL_CFG_NO_TEMPLATE_TEMPLATE_PARAMETERS)
+#if defined(BOOST_MPL_CFG_NO_TEMPLATE_TEMPLATE_PARAMETERS) && !BOOST_WORKAROUND( __BORLANDC__, >=0x590 )
 #   define BOOST_MPL_CFG_NO_QUOTE_TEMPLATE
 #endif

vs. modifying BOOST_MPL_CFG_NO_TEMPLATE_TEMPLATE_PARAMETERS condition in "aux_/config/ttp.hpp"?

Changes to "apply_wrap.hpp" and "quote.hpp" won't have any effect until we regenerate preprocessed headers. Were you testing the whole thing with BOOST_MPL_CFG_NO_PREPROCESSED_HEADERS defined?

Nicola Musatti — Wed, 08 Oct 2008 21:27:49 GMT

Replying to agurtovoy:

First of all. keep in mind that I'm not the original author of most of the patches I submitted in the last few weeks. These are the work of Alisdair Meredith and his collegues at CodeGear. I'm more or less just helping with getting them in shape for being applied to trunk.

Overall, it looks good. A couple of questions:

In "assert.hpp", why

-#if BOOST_WORKAROUND(__BORLANDC__, >= 0x560) && BOOST_WORKAROUND(__BORLANDC__, < 0x600) \
+#if BOOST_WORKAROUND(__BORLANDC__, BOOST_TESTED_AT(0x610)) \

vs.

-#if BOOST_WORKAROUND(__BORLANDC__, >= 0x560) && BOOST_WORKAROUND(__BORLANDC__, < 0x600) \
+#if BOOST_WORKAROUND(__BORLANDC__, >= 0x560) && BOOST_WORKAROUND(__BORLANDC__, BOOST_TESTED_AT(0x610)) \

I guess this is just meant as a simplification, as the last compiler before 5.6.0, i.e. 5.5.1 is about eight years old and not likely to be able to compile very much of current Boost anyway.

In "quote.hpp", why
-#if defined(BOOST_MPL_CFG_NO_TEMPLATE_TEMPLATE_PARAMETERS)
+#if defined(BOOST_MPL_CFG_NO_TEMPLATE_TEMPLATE_PARAMETERS) && !BOOST_WORKAROUND( __BORLANDC__, >=0x590 )
 #   define BOOST_MPL_CFG_NO_QUOTE_TEMPLATE
 #endif
vs. modifying BOOST_MPL_CFG_NO_TEMPLATE_TEMPLATE_PARAMETERS condition in "aux_/config/ttp.hpp"?

I have no idea, sorry...

Changes to "apply_wrap.hpp" and "quote.hpp" won't have any effect until we regenerate preprocessed headers. Were you testing the whole thing with BOOST_MPL_CFG_NO_PREPROCESSED_HEADERS defined?

Yes. My problem is I don't know how to regenerate the preprocessed headers for this compiler; still either that needs to be done or needs to be defined BOOST_MPL_CFG_NO_PREPROCESSED_HEADERS, if just on a temporary basis.

Cheers, Nicola

Nicola Musatti — Thu, 09 Oct 2008 22:07:45 GMT

I took the liberty of committing this patch to trunk, as tonight is the last chance to get it through a trunk regression test run and still make it into 1.37 . Ready to revert in case of problems.

Aleksey Gurtovoy — Fri, 10 Oct 2008 10:51:19 GMT

Thanks. I've made a couple of small fixes and regenerated corresponding preprocessed headers. Let's see how this turns out.

status changed; resolution set

Aleksey Gurtovoy — Sun, 12 Oct 2008 22:24:32 GMT

status assigned → closed
resolution → fixed

Merged to the release branch.