Boost C++ Libraries: Ticket #2346: [type_traits] Patches to improve support for CodeGear C++ Builder 2009

attachment set

Nicola Musatti — Thu, 18 Sep 2008 22:28:04 GMT

attachment → libs_type_traits.patch

status changed

John Maddock — Fri, 19 Sep 2008 12:44:57 GMT

status new → assigned

That looks OK, but can you:

1) Add the new config macros to Boost.Config as well? Not sure about this, but I think we are using BOOST_NO_* names for C++0x features as well: obviously that means changing the logic quite a bit and patching more config files... :-( 2) Please use the MPL macros for defining the traits classes rather than inheriting from integral_constant directly? Much as I truely hate those macros, they are necessary for full MPL interoperability unfortunately :-(

Cheers, John.

attachment set

Nicola Musatti — Sun, 05 Oct 2008 21:32:26 GMT

attachment → boost_type_traits.patch

Nicola Musatti — Sun, 05 Oct 2008 21:36:16 GMT

Replying to johnmaddock:

That looks OK, but can you:

1) Add the new config macros to Boost.Config as well? Not sure about this, but I think we are using BOOST_NO_* names for C++0x features as well: obviously that means changing the logic quite a bit and patching more config files... :-(

I ended up removing those I hadn't already submitted a patch for.

2) Please use the MPL macros for defining the traits classes rather than inheriting from integral_constant directly? Much as I truely hate those macros, they are necessary for full MPL interoperability unfortunately :-(

I just replaced the boost_type_traits.patch file with a new one. I changed the implementation approach to use intrinsics.hpp as much as possible and then I tried to be as little intrusive as I could. The resulting patch reduces type_traits failing tests to 4 for the bcc32 6.1.0 compiler. Let me know if you consider it acceptable.

anonymous — Tue, 07 Oct 2008 10:33:58 GMT

Thanks that looks fine - just one small query - for what compiler versions (and where) are you defining BOOST_ILLEGAL_CV_REFERENCES ?

Cheers, John.

Nicola Musatti — Tue, 07 Oct 2008 11:11:54 GMT

Replying to anonymous:

Thanks that looks fine - just one small query - for what compiler versions (and where) are you defining BOOST_ILLEGAL_CV_REFERENCES ?

That's defined in config/compiler/borland.hpp and applies to all versions of the compiler except the last one.

Cheers, Nicola

status changed; resolution set

Nicola Musatti — Fri, 24 Oct 2008 14:42:06 GMT

status assigned → closed
resolution → fixed

John applied my patches and merged them into the release branch a while ago.