Boost C++ Libraries: Ticket #2390: [patch] fix gcc-4.3 "unused" warning in floating_point_comparison

attachment set

Tue, 07 Oct 2008 19:17:32 GMT

attachment → float_comparison_unused.patch

patch against r49167

attachment set

Jürgen Hunold — Thu, 06 Nov 2008 20:48:05 GMT

attachment → floating_point_comparison.hpp.diff

Improved patch for all gcc-4.3 warnings

keywords set

Jürgen Hunold — Thu, 06 Nov 2008 20:58:45 GMT

keywords test floating point gcc 4.3 warnings added

I constructed an improved patch based on the ideas of Steven Watanabe for check_is_close and check_is_small.

And added a patch from John Maddock to add explicit parenthesis around potentially ambigous && and

The mailing list thread starts with: http://lists.boost.org/Archives/boost/2008/10/143756.php I've tested the patch with gcc-4.3.2 on SuSE-Linux 11 and msvc-9.0.

status changed; resolution set

Gennadiy Rozental — Fri, 21 Nov 2008 23:02:24 GMT

status new → closed
resolution → fixed

attachment set

Jürgen Hunold — Tue, 25 Nov 2008 08:53:31 GMT

attachment → floating_point_comparison.hpp.2.diff

Patch to add missing const qualifiers

status changed; resolution deleted

Jürgen Hunold — Tue, 25 Nov 2008 08:59:20 GMT

status closed → reopened
resolution fixed

Gennadiy, thanks for fixing this. Unfortunately, my patch was incomplete. I've compiled some other projects in the meantime and found that operator() in check_is_close and check_is_small needs to be "const" to get them working. This is due to the fact that Boost.Test now stores a "const&" to those two object. I've attached a small patch fixing this new issue. Tested on gcc-4.2/4.3 and msvc-9.0 SP1.

status changed; resolution set

Gennadiy Rozental — Tue, 18 Oct 2011 09:45:04 GMT

status reopened → closed
resolution → fixed

I believe this is already fixed in trunk