Boost C++ Libraries: Ticket #2423: map_array insert has invalid assertion

status changed

Gunter — Mon, 20 Oct 2008 21:44:08 GMT

status new → assigned

Replying to benson margulies <bimargulies@gmail.com>:

The external logic check in here appears to be wrong. The check is applied when the code sees the need to insert a new element in the underlying representation 'in the middle' -- the lower bound does not return end, and and the slot it returns does not have the correct index. The check requires the map to be empty or that the iterator is at the end, thus refusing to insert into the middle.

I see your point. Can you provide an example where the check fails although it should succeed?

(BTW: No one seems to use map_array any more because std::map can be used instead.)

Tue, 21 Oct 2008 00:15:41 GMT

I'm reasonably certain that all you have to do is insert out of order: 1, 10, 5. If that doesn't cooperate for you, I'll cook you a test case?

std::map has incredibly slow performance for iteration. If, like me, you need to rapidly iterate over the occupied slots of the sparse data structure, std::map is awful.

Gunter — Mon, 03 Nov 2008 22:53:57 GMT

(In [49578]) see #2423. removed the check because it makes absolutely no sense TODO: check the strange "optimization" of lower bound.

milestone changed

Gunter — Mon, 09 Mar 2009 20:29:47 GMT

milestone Boost 1.37.0 → Boost 1.39.0

merged changes into release branch

status changed; resolution set

Gunter — Thu, 18 Jun 2009 07:47:22 GMT

status assigned → closed
resolution → fixed

The fix seems to work without side effects. Thus I close this issue.