Boost C++ Libraries: Ticket #2428: [random] missing member initialization of generator_iterator ctor

attachment set

Wed, 22 Oct 2008 11:19:52 GMT

attachment → generator_iterator.hpp

cc changed

Daryle Walker — Mon, 08 Dec 2008 23:44:21 GMT

cc dwalker07@… added

The author of the UUID library recently under review noticed this too; and made a copy of generator_iterator that adds explicit default-initialization for the generator pointer member. I realized that the cached value member also needs default initialization (which that author skipped). You mentioned comparisons with the generator pointer, but both members need it, as your code states, because both members will get compared when checking two end iterators. BTW, do the initializations need to be filled in with "0," or can nothing between the parentheses be used?

anonymous — Tue, 09 Dec 2008 09:15:44 GMT

In case of the mersenne_twister generator the Generator::result_type is UIntType. Probably more correct would be initialization with Generator::result_type(), i.e.

generator_iterator() : m_g(0), m_value(Generator::result_type()) {}

Default construction of integral types are guaranteed to be 0.

status changed; resolution set

Steven Watanabe — Wed, 09 Jun 2010 02:18:48 GMT

status new → closed
resolution → wontfix

Use the new function_input_iterator in Boost.Iterator instead. (See #2893). I'm going to deprecate generator_iterator as it's behavior can be somewhat odd.