Boost C++ Libraries: Ticket #2432: spirit/home/classic/utility/impl/chset/basic_chset.hpp misses include <limits.h> https://svn.boost.org/trac10/ticket/2432 <p> spirit/home/classic/utility/impl/chset/basic_chset.hpp uses the macro CHAR_BIT without including &lt;limits.h&gt; </p> <p> Our scenario is, that two objects use chset&lt;char&gt; and one object has included &lt;limits.h&gt; and another one hasn't. This results in an ODR violation for basic_chset&lt;char&gt;. </p> <p> This happens with GCC-4.3.2. If boost were clean enough to use '-Wundef', to warn on undefined macros, this bug would have be found much earlier. </p> en-us Boost C++ Libraries /htdocs/site/boost.png https://svn.boost.org/trac10/ticket/2432 Trac 1.4.3 Richard Webb <richard.webb@…> Sat, 30 May 2009 17:41:07 GMT <link>https://svn.boost.org/trac10/ticket/2432#comment:1 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/2432#comment:1</guid> <description> <p> The current version of basic_chset.hpp includes &lt;climits&gt; (which includes limits.h). Problem fixed? </p> </description> <category>Ticket</category> </item> <item> <dc:creator>Steven Watanabe</dc:creator> <pubDate>Sun, 31 May 2009 14:47:16 GMT</pubDate> <title/> <link>https://svn.boost.org/trac10/ticket/2432#comment:2 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/2432#comment:2</guid> <description> <p> It was fixed in classic spirit in <a class="changeset" href="https://svn.boost.org/trac10/changeset/49708" title="restoring version.hpp and bumping the version to 2.0">[49708]</a> and merged to release in <a class="changeset" href="https://svn.boost.org/trac10/changeset/50611" title="Spirit: Merging from trunk">[50611]</a>, but Spirit 2 has the same problem. </p> <p> It [source:/trunk/boost/spirit/home/qi/char/detail/basic_chset.hpp@52603#L133 uses CHAR_BIT] but [source:/trunk/boost/spirit/home/qi/char/detail/basic_chset.hpp@52603#L16 doesn't #include &lt;climits&gt;] </p> </description> <category>Ticket</category> </item> <item> <dc:creator>Hartmut Kaiser</dc:creator> <pubDate>Tue, 02 Jun 2009 01:18:15 GMT</pubDate> <title>status changed; resolution set https://svn.boost.org/trac10/ticket/2432#comment:3 https://svn.boost.org/trac10/ticket/2432#comment:3 <ul> <li><strong>status</strong> <span class="trac-field-old">new</span> → <span class="trac-field-new">closed</span> </li> <li><strong>resolution</strong> → <span class="trac-field-new">fixed</span> </li> </ul> <p> (In <a class="changeset" href="https://svn.boost.org/trac10/changeset/53558" title="Spirit: fix #2432">[53558]</a>) Spirit: fix <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/2432" title="#2432: Bugs: spirit/home/classic/utility/impl/chset/basic_chset.hpp misses include ... (closed: fixed)">#2432</a> </p> Ticket Hartmut Kaiser Tue, 02 Jun 2009 01:19:08 GMT <link>https://svn.boost.org/trac10/ticket/2432#comment:4 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/2432#comment:4</guid> <description> <p> (In <a class="changeset" href="https://svn.boost.org/trac10/changeset/53559" title="Spirit: fix #2432">[53559]</a>) Spirit: fix <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/2432" title="#2432: Bugs: spirit/home/classic/utility/impl/chset/basic_chset.hpp misses include ... (closed: fixed)">#2432</a> </p> </description> <category>Ticket</category> </item> </channel> </rss>