Boost C++ Libraries: Ticket #2473: unsigned integers going into interval of doubles get wrongly negated

attachment set

Tue, 04 Nov 2008 13:12:55 GMT

attachment → bug_unsigned_boost.cc

very short example exhibiting bug

Gunter — Thu, 12 Mar 2009 22:24:27 GMT

This problem causes the failure of test7 of ublas. I'd appreciate if someone finds time to fix it.

Gunter — Thu, 12 Mar 2009 22:49:51 GMT

I tracked the source of the problem down to rounded_arith.hpp:93 where (-v) is computed although the type of v is and unsigned integer.

Additionally I wonder why the constructor of interval<T> is template <T1, T2> interval(T1, T2) and not simply interval(T,T). The latter constructor would enforce the conversion to the correct type and prevent the shown bug.

Gunter — Thu, 02 Apr 2009 22:36:44 GMT

(In [52147]) ublas/doc/samples/ex_triangular.cpp: added new example ublas/doc/samples/Jamfile.v2: added build section for ex_triangular ublas/doc/container_concept.htm: fixed wrong description of array_type ublas/doc/triangular.htm: fixed lower/upper confusion and added link to ex_triangular

ublas/test/test_lu.cpp: added unit test for LU decomposition ublas/test/triangular_access.cpp: added unit test for accessing triangular/symmetric matrices ublas/test/triangular_layout.cpp: added unit test for testing storage layout of triangular/symmetric matrices ublas/test/common/testhelper.hpp: support routines for new unit tests

ublas/test/CMakeLists.txt: added new tests (still experimental) test_lu, triangular_access. triangular_layout

ublas/test/Jamfile.v2:

added new tests (still experimental) test_lu, triangular_access. triangular_layout disabled broken test7 (maybe a fix of boost::interval is needed, see #2473)

ublas/test/test71.cpp, ublas/test/test73.cpp, ublas/test/test7.cpp:

added first fixes to support boost::interval as scalar type

ublas/test/common/init.hpp:

initialize all matrices/vectors with floats instead of (unsigned) ints this helps to fix broken test7 for boost::interval