Boost C++ Libraries: Ticket #2501: upgrade_to_unique_lock doesn't compile on C++0x mode

anonymous — Thu, 21 May 2009 00:39:05 GMT

This one still does not work :(

Fri, 05 Jun 2009 15:51:01 GMT

The last error is due to a trivial typo fixed by

--- boost-1_39/boost/thread/locks.hpp
+++ boost/thread/locks.hpp
@@ -772,7 +772,7 @@
         other.is_locked=false;
         if(is_locked)
         {
-            m.unlock_upgrade_and_lock();
+            m->unlock_upgrade_and_lock();
         }
     }
 #else

Fri, 05 Jun 2009 16:03:55 GMT

The second error is because upgrade_lock has no handling for the case when BOOST_HAS_RVALUE_REFS is defined. In that case boost::move() returns an rvalue reference rather than a boost::thread_move_t, but upgrade_lock can only handle the move wrapper, not an rvalue reference.

attachment set

Fri, 05 Jun 2009 16:34:33 GMT

attachment → 2501.patch

patch for boost/thread/locks.hpp

milestone changed; cc set

Fri, 05 Jun 2009 16:43:21 GMT

cc jwakely.boost@… added
milestone Boost 1.38.0 → Boost 1.40.0

that patch against boost 1.39.0 enables C++0x move support for upgrade_lock, fixing the testcase above.

Rodolfo, could you test it as well? It would be good to fix it for 1.40.0

anonymous — Sat, 05 Sep 2009 16:54:12 GMT

Still there in 1.40

anonymous — Fri, 26 Mar 2010 02:48:34 GMT

I applied the patch on 1.42 and after some minor adjustments it worked well, IMHO it's fine to go into 1.43.

Rodolfo Lima — Mon, 12 Apr 2010 16:52:15 GMT

Any hope that it will get into 1.43?

status changed; resolution set

Anthony Williams — Tue, 20 Apr 2010 15:05:59 GMT

status new → closed
resolution → fixed

Fixed on trunk

cc, status, version, milestone changed; resolution deleted

Tue, 15 Jun 2010 15:30:01 GMT

cc braden@… added
status closed → reopened
version Boost Release Branch → Boost Development Trunk
resolution fixed
milestone Boost 1.40.0 → Boost 1.44.0

Reopening in light of http://lists.boost.org/boost-users/2010/06/59926.php.

status changed; resolution set

anonymous — Thu, 08 Jul 2010 16:29:39 GMT

status reopened → closed
resolution → fixed

Fixed on trunk

status changed; resolution deleted

anonymous — Fri, 22 Oct 2010 15:52:30 GMT

status closed → reopened
resolution fixed

This still does not compile in vs2010 on trunk 1.44.0.

type changed

viboes — Thu, 28 Oct 2010 18:05:46 GMT

type Bugs → Patches

Changed to Patch as patch exists.

milestone changed

viboes — Sat, 03 Dec 2011 11:20:30 GMT

milestone Boost 1.44.0 → To Be Determined

type changed

viboes — Sat, 03 Dec 2011 23:35:57 GMT

type Patches → Bugs

cc changed

viboes — Sat, 03 Dec 2011 23:39:22 GMT

cc viboes added

Replying to anonymous:

This still does not compile in vs2010 on trunk 1.44.0.

Hi,

This ticket was for gcc-4.3.2 (and gcc-4.4.0). Please, even if this is an old ticket, could you post the errors you found now and post them here or even create another ticket and close this one?

owner, status changed

viboes — Sun, 04 Dec 2011 23:09:14 GMT

owner changed from Anthony Williams to viboes
status reopened → new

I have tried with MSVC 2010 and it works

#include <boost/thread/shared_mutex.hpp>
#include <boost/thread/locks.hpp>
int main() {
  boost::shared_mutex mtx; boost::upgrade_lock<boost::shared_mutex> lk(mtx);
  boost::upgrade_to_unique_lock<boost::shared_mutex> lk2(lk);
  return 0;
}

Could you try again on trunk?

type changed

viboes — Wed, 07 Dec 2011 22:45:16 GMT

type Bugs → Support Requests

Moved to support request until resolution clarified

keywords set

viboes — Sun, 11 Dec 2011 11:39:48 GMT

keywords move added

The is an action point to use Boost.Move. Could we consider this as a duplicate of #6194 Adapt to Boost.Move.

status changed; resolution set; milestone deleted

viboes — Sat, 31 Dec 2011 15:25:29 GMT

status new → closed
resolution → fixed
milestone To Be Determined

Closed. Please reopen if this doesn't works on trunk 1.49.