Boost C++ Libraries: Ticket #2757: Warning C4244: conversion from 'int' to 'unsigned short' in microsec_time_clock.hpp line 103

james@… — Fri, 13 Feb 2009 09:25:25 GMT

Line 99ff:

...
  std::tm curr;
  std::tm* curr_ptr = converter(&t, &curr);
  date_type d(static_cast<date_type::year_type::value_type>(curr_ptr->tm_year + 1900),
    static_cast<date_type::month_type::value_type>(curr_ptr->tm_mon + 1),
    static_cast<date_type::day_type::value_type>(curr_ptr->tm_mday));
...

This will suppress this warning.

type changed

gareth.sylvester-bradley@… — Thu, 26 Nov 2009 10:58:21 GMT

type Bugs → Patches

FWIW, this problem still applies to current release (1.41.0) and trunk. The file <boost/date_time/microsec_time_clock.hpp> ends up included in a lot of situations, e.g. via Boost.Thread, so I see this warning many many many times in my code base.

I independently reinvented the same patch as the OP. Unfortunately I didn't think to check Trac until I had one - any chance of this being applied so nobody else has to..?

version, milestone changed

james@… — Thu, 08 Apr 2010 12:32:47 GMT

version Boost 1.38.0 → Boost Development Trunk
milestone Boost 1.39.0 → Boost 1.43.0

Please fix this... The warnings are annoying.

Andrey Semashev — Thu, 15 Apr 2010 15:24:00 GMT

(In [61293]) Refs #2757. Added explicit casts to avoid warnings on MSVC.

gareth.sylvester-bradley@… — Thu, 15 Apr 2010 18:24:22 GMT

Thank you Andrey!

I assume this will have to wait for merge until 1.44.0?

Andrey Semashev — Fri, 16 Apr 2010 02:45:10 GMT

Yes, the problem is not that critical to push it for 1.43.

status changed; resolution set

Andrey Semashev — Mon, 10 May 2010 09:15:49 GMT

status new → closed
resolution → fixed

(In [61892]) Fixes #2757. Added explicit casts to avoid warnings on MSVC.

michael.cowperthwaite@… — Mon, 14 May 2012 17:30:38 GMT

Seeing this warning with Boost 1.49, MSVS 2008. The warnings are not suppressible using MS's #pragma warning feature.

anonymous — Wed, 23 May 2012 17:54:35 GMT

Replying to michael.cowperthwaite@…:

Seeing this warning with Boost 1.49, MSVS 2008. The warnings are not suppressible using MS's #pragma warning feature.

Sorry, I was wrong; warning at different location. See new ticket #6936.