Boost C++ Libraries: Ticket #2842: dynamic_bitset.hpp fails to compile with g++ (Ubuntu 4.3.3-5ubuntu2) 4.3.3

Thu, 30 Apr 2009 11:14:58 GMT

The part that is not identified as constant is 'no_padding', participant in 'mode'. The other part, 'enough_table_width' is correctly identified as const.

Thu, 30 Apr 2009 11:22:20 GMT

Solution (apparently) found: The current file documents something introduced for GCC 3.4:

NOTE: Explicitly qualifying "bits_per_block" to workaround regressions of gcc 3.4.x const bool no_padding =

dynamic_bitset<Block, Allocator>::bits_per_block

CHAR_BIT * sizeof(Block);

Removing the explicit qualification compiles with GCC 4.3. To be tested: does the compiled object work OK?

const bool no_padding = bits_per_block == CHAR_BIT * sizeof(Block);

HTH

attachment set

zaravalle@… — Thu, 07 May 2009 09:17:06 GMT

attachment → dynamic_bitset.patch

Suggested patch that fixes this ticket

status changed; resolution set

zaravalle@… — Thu, 07 May 2009 09:20:42 GMT

status new → closed
resolution → fixed

Attached file seems to correct this problem. Explicit qualification of bits_per_block breaks compilation undef gccx 4.3, so the patch just detects this specific compiler and version (and later versions, also), and does not make the explicit qualification in such case.

Works OK with gcc 4.1 (Centos 5.x) and gcc 4.3 (ubuntu 9.04)

status changed; resolution deleted

anonymous — Thu, 07 May 2009 13:03:37 GMT

status closed → reopened
resolution fixed

zaravalle@… — Thu, 07 May 2009 13:05:16 GMT

I have reopened it as I accidentally closed it, but the proposed fix is still valid, from my point of view.

cc set

Daniel James — Mon, 11 May 2009 00:16:35 GMT

cc daniel_james@… added

Hi, I was just looking at this, as I promised I would. But it seems that someone beat me to it and didn't say anything. Changes in trunk: [52879], [52880], [52881].

status changed; resolution set

zaravalle@… — Mon, 11 May 2009 05:43:45 GMT

status reopened → closed
resolution → fixed

Thanks to all. I have now learned something else about versions and patch levels, by loking at the definitive solution. I suppose now is the right time to close the ticket!