Boost C++ Libraries: Ticket #2885: [smart_ptr] g++/MIPS support for lockless sp_counted_base

attachment set

Tue, 24 Mar 2009 16:40:35 GMT

attachment → boost_1_38_0.sp_counted_base_mips.patch

status changed

Peter Dimov — Tue, 24 Mar 2009 21:32:48 GMT

status new → assigned

Thanks.

Is there a reason you use subu with a temp register instead of addiu with -1 in atomic_decrement?

Peter Dimov — Tue, 24 Mar 2009 21:44:59 GMT

Another question... does g++/MIPS implement the sync intrinsics?

Tue, 24 Mar 2009 21:52:14 GMT

No good reason. ;)

This inline assembly was originally written for atomic subtraction rather than atomic decrement, thus the extra input parameter to the asm block. I believe GNU's as converts "subu %0, %1, 1" to "addiu %0, %1, -1" on the fly however I'm okay with changing this to addiu.

Would you like to me to reattach the patch?

As far as g++/MIPS support for __sync, the newest g++/MIPS toolchain I have access to is 4.1.2 and they are not implemented there.

Peter Dimov — Tue, 24 Mar 2009 22:10:34 GMT

Would you like to me to reattach the patch?

Yes please.

Actually, just attach sp_counted_base_gcc_mips.hpp. The headers have been moved for 1.39 so the patch will not apply cleanly anyway.

Are you interested in fixing spinlock.hpp as well?

attachment set

Wed, 25 Mar 2009 19:52:42 GMT

attachment → sp_counted_base_gcc_mips.hpp

Wed, 25 Mar 2009 19:53:49 GMT

Reattached.

We don't use user-mode spinlocks - we don't have the priority schemes in place to make it safe - so I can't help you there. Sorry.

Peter Dimov — Thu, 26 Mar 2009 00:18:01 GMT

(In [51978]) Added g++/MIPS support submitted by David Joyner. Refs #2885.

Peter Dimov — Thu, 26 Mar 2009 00:22:44 GMT

I've applied your patch to the SVN trunk; thanks again. If everything looks (and tests) OK for you, I'll merge the changes to the release branch so that they surface in 1.39.

Thu, 26 Mar 2009 04:31:32 GMT

Tried the build from SVN trunk. The #include of sp_typeinfo.hpp needs minor fixup:

-#include "sp_typeinfo.hpp"
+#include <boost/detail/sp_typeinfo.hpp>

Compiles fine after that change.

Peter Dimov — Thu, 26 Mar 2009 12:47:29 GMT

(In [51985]) Fix sp_typeinfo.hpp include. Refs #2885.

status changed; resolution set

Peter Dimov — Fri, 27 Mar 2009 13:10:48 GMT

status assigned → closed
resolution → fixed

(In [52016]) Merge [51978], [51985] to release. Closes #2885.