Boost C++ Libraries: Ticket #2886: Boost.Array gives MS warnings C4510 and C4610

attachment set

Paul A. Bristow — Wed, 25 Mar 2009 15:41:27 GMT

attachment → array_warnings.patch

suppress warnings in Boost.array

Steven Watanabe — Tue, 19 May 2009 02:56:23 GMT

Why array<const double, 99> rather than const array<double, 99>?

Also, array<const double, 99> does not quite work correctly, because iterator::value_type is const double rather than double.

Paul A. Bristow — Tue, 19 May 2009 16:53:07 GMT

Replying to steven_watanabe:

Why array<const double, 99> rather than const array<double, 99>?

Also, array<const double, 99> does not quite work correctly, because iterator::value_type is const double rather than double.

You are right, as always.

Asking for an array of const doubles still *feels* resonable.

So, since I am sure I am not the only one to suffer from constant const confusion, it might be useful to document that const array is best, and briefly why?

anonymous — Fri, 22 May 2009 17:08:16 GMT

Replying to pbristow:

Asking for an array of const doubles still *feels* resonable.

So, since I am sure I am not the only one to suffer from constant const confusion, it might be useful to document that const array is best, and briefly why?

Sure. Now that I have a working doc toolchain again...

owner changed

Marshall Clow — Fri, 29 Jan 2010 18:13:25 GMT

owner changed from No-Maintainer to Marshall Clow

Some of this should be fixed in the 1.42 release candidate. Paul, can you check and see if this still occurs there? If so, I can add more warning suppression.

status changed

Marshall Clow — Fri, 29 Jan 2010 18:13:47 GMT

status new → assigned

Paul A. Bristow — Mon, 01 Feb 2010 10:46:02 GMT

Replying to marshall:

I haven't got 1.42 rc yet, but the code appears unchanged in trunk?

I am still not clear if the warning should be suppressed (I suspect not suppressing is best) but the array docs should warn that to get an array with const values

boost::array<const double, 2> stuff = { 1.2, 3.4}; warnings

so use instead

const boost::array<double, 2> stuff = { 1.2, 3.4}; No warnings.

As Steven says, this is "because iterator::value_type is const double rather than double. "

(But the docs appear to me to be in XML :-( so editing may be troublesome?).

Marshall Clow — Mon, 01 Feb 2010 17:25:35 GMT

Replying to pbristow:

Replying to marshall:

I haven't got 1.42 rc yet, but the code appears unchanged in trunk?

Well, the code has been changed in the trunk. There was some warning suppression (though not specifically 4510 and 4610) added to that file after this bug was opened. I wanted to make sure (not having access to VC9) that this didn't take care of the problems reported here.

status changed; resolution set

Marshall Clow — Thu, 04 Feb 2010 18:22:17 GMT

status assigned → closed
resolution → fixed

(In [59476]) Applied patches to fix #2886

dimentiy — Sun, 19 Dec 2010 23:09:13 GMT

I've got those two in 1.41 and can't avoid it. Push and pop around the #include <boost/array.hpp> don't work (vc80). :(