Boost C++ Libraries: Ticket #2887: mersenne_twister generated copy ctor overloaded by a template ctor

corlay@… — Thu, 26 Mar 2009 15:34:56 GMT

In mersenne_twister.hpp, replacing

template<class Generator>
  explicit mersenne_twister(Generator & gen) { seed(gen); }

  template<class Generator>
	explicit mersenne_twister(Generator & gen, typename disable_if< is_same<Generator,mersenne_twister>,int >::type = 0) { seed(gen); }

and add includes

#include <boost/utility/enable_if.hpp>
#include  <boost/type_traits/is_same.hpp>

seems to solve it. No need to handle with the const case.

Then, one has to do it for other generators and, in pass_through_engine.hpp, one can then replace

  explicit pass_through_engine(UniformRandomNumberGenerator rng)
    // make argument an rvalue to avoid matching Generator& constructor
    : _rng(static_cast<typename helper_type::rvalue_type>(rng))
  { }

  explicit pass_through_engine(UniformRandomNumberGenerator rng) : _rng(rng)
  { }

keywords, summary changed

anonymous — Sat, 28 Mar 2009 10:08:29 GMT

keywords Copy ctor Bug added; boost::random removed
summary boost::mersenne_twister copy constructor → mersenne_twister generated copy ctor overloaded by a template ctor

attachment set

corlay@… — Tue, 31 Mar 2009 16:13:08 GMT

attachment → patchfile.patch

unified diff for the proposed correction

status changed; resolution set

Steven Watanabe — Sat, 06 Jun 2009 19:41:40 GMT

status new → closed
resolution → fixed

(In [53699]) Fix overload resolution for generator constructors/seed. Fixes #351. Fixes #2424. Fixes #2887