Boost C++ Libraries: Ticket #2909: [Fix in git] Wrong type signatures?

cc set

Haoyu Bai — Fri, 03 Apr 2009 13:16:59 GMT

cc divinekid@… added

Dave Abrahams — Mon, 06 Apr 2009 10:03:16 GMT

The best way to know if these are bugs that need to be fixed is to produce test cases (a .cpp and a matching .py file—see this directory for examples) that currently fail and would stop failing if the fixes were made. Can you do that and post an attachment?

Thanks!

attachment set

Haoyu Bai — Wed, 08 Apr 2009 07:50:33 GMT

attachment → typetypo.diff

Patch to fix the typo

attachment set

Haoyu Bai — Wed, 08 Apr 2009 07:51:58 GMT

attachment → typetypo.cpp

Testcase showing the problem.

attachment set

Haoyu Bai — Wed, 08 Apr 2009 07:52:57 GMT

attachment → typetypo.py

Testcase showing the problem.

Haoyu Bai — Wed, 08 Apr 2009 08:08:13 GMT

Testcase and patch attached.

Without the patch, the test giving the following result:

Docstring say:
return_longlong() -> int :
    C++ signature :
        long long return_longlong()
But actually type of return value is: <type 'long'>
Docstring say:
return_wstring() -> str :
    C++ signature :
        std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > return_wstring()
But actually type of return value is: <type 'unicode'>

Notice the "return_longlong() -> int" and "return_wstring() -> str".

With the patch, the result seems correct:

Docstring say:
return_longlong() -> long :
    C++ signature :
        long long return_longlong()
But actually type of return value is: <type 'long'>
Docstring say:
return_wstring() -> unicode :
    C++ signature :
        std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > return_wstring()
But actually type of return value is: <type 'unicode'>

Also, this patch don't affect other test cases, as they are all passed. I think it is just related to the docstring and won't touch any other things.

owner changed

troy d. straszheim — Mon, 12 Oct 2009 21:37:30 GMT

owner changed from Dave Abrahams to troy d. straszheim

Looks like the fix made it to the trunk, but not the test, and I notice:

print return_string.doc

return_string() -> str :

C++ signature :

std::string return_string()

print return_wstring.doc

return_wstring() -> unicode :

C++ signature :

std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > return_wstring()

that that basic_string<wchar... should be simplified to std::wstring for readability. Working on it.

summary changed

troy d. straszheim — Mon, 12 Oct 2009 22:44:10 GMT

summary Wrong type signatures? → [Fix in git] Wrong type signatures?

Fix here:

http://gitorious.org/~straszheim/boost/straszheim/commit/aeefdf7abca8c33c25a98a5f7fc78e4e888f9c94

also clean up printing of std::wstring as the gcc demangler was being messy about it.