attachment set

fhess — Fri, 03 Apr 2009 21:28:16 GMT

attachment → shared_from_this.hpp

free boost::shared_from_this template function

cc set

Mon, 08 Jun 2009 17:06:33 GMT

cc jwakely.boost@… added

This idea is interesting, but I don't like the name because there is no this pointer in the context of a non-member function. Maybe I'm wrong, but I regard the "this" in shared_from_this as referring to this. How about shared_from instead?

X* p = ...;
shared_ptr<X> sp = shared_from(p);

It also seems odd to have a class called enable_shared_from_this_base which has a base class called enable_shared_from_this! I understand the reasons, but it seems backwards at first glance.

Renaming the free function to shared_from means your new class could be renamed enable_shared_from. Users who only want to use the free function can derive their class X from enable_shared_from (and don't need to care that calling p->enable_shared_from_this() returns a shared_ptr<enable_shared_from> not a shared_ptr<X>) while users who want to use either the free function or the existing member function can continue to derive from enable_shared_from_this<X>.

owner, milestone changed

Peter Dimov — Tue, 01 Dec 2009 01:49:22 GMT

owner changed from Peter Dimov to Frank Mori Hess
milestone Boost 1.39.0 → To Be Determined

Boost C++ Libraries: Ticket #2911: shared_from_this free function

attachment set

cc set

owner, milestone changed