Boost C++ Libraries: Ticket #2924: BSD and darwin gcc standard libraries aren't always detected.

attachment set

Daniel James — Wed, 08 Apr 2009 06:10:39 GMT

attachment → config.patch

John Maddock — Wed, 08 Apr 2009 10:06:17 GMT

Sigh... looks like someone broke this in https://svn.boost.org/trac/boost/changeset/52104, can you go please ahead and commit, and check the release branch as well?

Thanks, John.

cc set

John Maddock — Wed, 08 Apr 2009 10:55:29 GMT

cc ddeakins@… added

Looks like it's broken for Borland as well as all the glibc platforms, I'm CC'ing Dave Deakins as well since he caused the breakage :-)

John.

status changed; resolution set

Daniel James — Wed, 08 Apr 2009 10:56:27 GMT

status new → closed
resolution → fixed

(In [52246]) Include <utility> for some versions of gcc's library.

Sometimes gcc's <cstddef> doesn't define the C++ macros, so check for it and include <utility> in that case. Also remove a workaround from container_fwd.hpp

Fixes #2924.

status changed; resolution deleted

Daniel James — Wed, 08 Apr 2009 11:02:12 GMT

status closed → reopened
resolution fixed

Sorry, I only read your comment after committing. Reopening for Borland.

version changed

Daniel James — Wed, 08 Apr 2009 11:03:06 GMT

version Boost 1.38.0 → Boost Development Trunk

Oh, and this is only on trunk. The release branch is fine.

Daniel James — Wed, 08 Apr 2009 11:07:23 GMT

Actually, it isn't. I had an old version. I think we should revert the change on release. Especially since we're coming up to the deadline.

John Maddock — Wed, 08 Apr 2009 11:14:09 GMT

Nod, I agree. If David can fix the regressions on Trunk we can always merge to release branch for the next release.

John.

David Deakins — Wed, 08 Apr 2009 14:49:30 GMT

(In [52254]) Reverted change in boost/config/select_stdlib_config.hpp change in rev 52221. Some gcc and Borland stdlibs don't pick up the C++ macros needed for stdlib detection from <cstddef>. See ticket 2924.

David Deakins — Wed, 08 Apr 2009 14:53:10 GMT

My bad. Change reverted on the release branch. I'll look into the Borland issue on the trunk right away and see if there is an easy patch for it.

David Deakins — Wed, 08 Apr 2009 16:46:25 GMT

Ok, I just checked in a change to the trunk that will hopefully remove the regressions. I'll keep an eye on the Borland results and close the issue if the problem is resolved.

status changed; resolution set

David Deakins — Sat, 11 Apr 2009 04:21:37 GMT

status reopened → closed
resolution → fixed

The trunk results have cycled and it appears that with the revised change the Borland and gcc results are correct again. I believe this issue is now closed.

Daniel James — Sat, 11 Apr 2009 08:49:35 GMT

(In [52324]) Merge quickbook and hash changelogs. Tweak gcc detection in container_fwd.hpp

Merged revisions 52084,52245-52246,52304,52320,52323 via svnmerge from https://svn.boost.org/svn/boost/trunk

........

r52084 | danieljames | 2009-03-31 20:43:58 +0100 (Tue, 31 Mar 2009) | 1 line

Changelog for unordered and hash.

........

r52245 | danieljames | 2009-04-08 06:51:31 +0100 (Wed, 08 Apr 2009) | 5 lines

Detect gcc stdlib for gcc 4.0.1.

For some reason the normal macros aren't defined for the standard library that comes with gcc 4.0.1 (although maybe just on BSDs?). So try to detect the library for that compiler.

........

r52246 | danieljames | 2009-04-08 11:56:22 +0100 (Wed, 08 Apr 2009) | 7 lines

Include <utility> for some versions of gcc's library.

Sometimes gcc's <cstddef> doesn't define the C++ macros, so check for it and include <utility> in that case. Also remove a workaround from container_fwd.hpp

Fixes #2924.

........

r52304 | danieljames | 2009-04-10 20:25:32 +0100 (Fri, 10 Apr 2009) | 4 lines

Don't use debug containers on darwin.

I'm getting errors from the darwin 4.2 debug containers which appear to a problem with its implementation.

........

r52320 | danieljames | 2009-04-11 08:53:59 +0100 (Sat, 11 Apr 2009) | 1 line

Don't need to include utility now that select_stdlib has been fixed.

........

r52323 | danieljames | 2009-04-11 09:26:20 +0100 (Sat, 11 Apr 2009) | 1 line

Also don't need to check for _GLIBCXX_CSTDDEF.

........

Daniel James — Sat, 11 Apr 2009 12:42:34 GMT

Oops, sorry that got posted to this ticket. I didn't merge any changes to config there, as the later patches reverted the changes I made to config.