Boost C++ Libraries: Ticket #2932: iostreams file_descriptor: possible throw of exception in call to destructor

cc, severity, milestone changed

Thu, 30 Jul 2009 08:41:45 GMT

cc gareth.sylvester-bradley@… added
severity Problem → Showstopper
milestone Boost 1.39.0 → Boost 1.40.0

IMHO throwing exceptions in destructors should be avoided.

I'd put it stronger than that! This just bit my product for real, causing a std::terminate() due to an exception from this destructor during stack unwinding for another exception (in fact a "bad close" from an explicit call to close() on the same stream).

FWIW, I was using the 1.39.0 release, where the problem is present here -

https://svn.boost.org/trac/boost/browser/tags/release/Boost_1_39_0/boost/iostreams/device/file_descriptor.hpp#L89

       ~impl()
        { if (flags_ & close_on_exit) close_impl(*this); }

IMHO, this needs to be patched ASAP.

Marshall Clow — Mon, 30 Nov 2009 01:03:30 GMT

This issue was patched 6 months ago. The fix is in the 1.41.0 release. is it time to close this bug?

status, version changed; resolution set

Mon, 30 Nov 2009 09:01:33 GMT

status new → closed
version Boost Development Trunk → Boost 1.41.0
resolution → fixed

Replying to marshall:

This issue was patched 6 months ago. The fix is in the 1.41.0 release. is it time to close this bug?

Marshall, I'm not sure to whom your question was addressed, but as one of the reporters, the version in 1.41.0 looks good to me; hope it's ok that I'm changing resolution to 'fixed'. Many thanks to Beman that the fix didn't languish on the trunk for more than six months!