Boost C++ Libraries: Ticket #2963: Inspect tool fails when no errors are found https://svn.boost.org/trac10/ticket/2963 <p> The Boost inspection program crashes (on OS X, with a null pointer dereference) when run on a directory containing no issues. In particular, line 453 (the first line of the body of worst_offenders_count()) of inspect.cpp (in <a class="changeset" href="https://svn.boost.org/trac10/changeset/52517" title="Fix float support on vxWorks. Thanks to Dustin Spicuzza. Fixes #2957 ...">r52517</a>) accesses msgs.begin(), which is invalid when msgs is empty, leading to a segmentation fault. </p> en-us Boost C++ Libraries /htdocs/site/boost.png https://svn.boost.org/trac10/ticket/2963 Trac 1.4.3 Jeremiah Willcock Tue, 21 Apr 2009 16:47:23 GMT attachment set https://svn.boost.org/trac10/ticket/2963 https://svn.boost.org/trac10/ticket/2963 <ul> <li><strong>attachment</strong> → <span class="trac-field-new">inspect.patch</span> </li> </ul> <p> Patch to fix bug. </p> Ticket Jeremiah Willcock Tue, 21 Apr 2009 16:48:23 GMT <link>https://svn.boost.org/trac10/ticket/2963#comment:1 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/2963#comment:1</guid> <description> <p> I attached a patch to fix the problem. I just changed the code such that worst_offenders_count() just returns when there are no problems found. </p> </description> <category>Ticket</category> </item> <item> <dc:creator>anonymous</dc:creator> <pubDate>Tue, 21 Apr 2009 17:52:34 GMT</pubDate> <title>owner changed https://svn.boost.org/trac10/ticket/2963#comment:2 https://svn.boost.org/trac10/ticket/2963#comment:2 <ul> <li><strong>owner</strong> changed from <span class="trac-author">John Maddock</span> to <span class="trac-author">René Rivera</span> </li> </ul> Ticket Jeremiah Willcock Wed, 13 May 2009 22:53:33 GMT milestone changed https://svn.boost.org/trac10/ticket/2963#comment:3 https://svn.boost.org/trac10/ticket/2963#comment:3 <ul> <li><strong>milestone</strong> <span class="trac-field-old">Boost 1.39.0</span> → <span class="trac-field-new">Boost 1.40.0</span> </li> </ul> <p> I can commit the patch I attached earlier if you want. </p> Ticket Daniel James Thu, 14 May 2009 09:58:47 GMT <link>https://svn.boost.org/trac10/ticket/2963#comment:4 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/2963#comment:4</guid> <description> <p> The patch looks fine to me, you should just go ahead with it. Inspect doesn't really have a maintainer, so you shouldn't wait for permission. If you want a code review the best place to ask is the development list. </p> </description> <category>Ticket</category> </item> <item> <dc:creator>Jeremiah Willcock</dc:creator> <pubDate>Thu, 14 May 2009 14:50:58 GMT</pubDate> <title>status changed; resolution set https://svn.boost.org/trac10/ticket/2963#comment:5 https://svn.boost.org/trac10/ticket/2963#comment:5 <ul> <li><strong>status</strong> <span class="trac-field-old">new</span> → <span class="trac-field-new">closed</span> </li> <li><strong>resolution</strong> → <span class="trac-field-new">fixed</span> </li> </ul> <p> (In <a class="changeset" href="https://svn.boost.org/trac10/changeset/52995" title="Fixes #2963">[52995]</a>) Fixes <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/2963" title="#2963: Bugs: Inspect tool fails when no errors are found (closed: fixed)">#2963</a> </p> Ticket Daniel James Sat, 16 May 2009 14:37:03 GMT <link>https://svn.boost.org/trac10/ticket/2963#comment:6 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/2963#comment:6</guid> <description> <p> (In <a class="changeset" href="https://svn.boost.org/trac10/changeset/53049" title="Merge inspect fix for when there are no errors. Merged revisions ...">[53049]</a>) Merge inspect fix for when there are no errors. </p> <p> Merged revisions 52995 via svnmerge from <a class="ext-link" href="https://svn.boost.org/svn/boost/trunk"><span class="icon">​</span>https://svn.boost.org/svn/boost/trunk</a> </p> <p> ........ </p> <blockquote> <p> <a class="changeset" href="https://svn.boost.org/trac10/changeset/52995" title="Fixes #2963">r52995</a> | jewillco | 2009-05-14 15:50:56 +0100 (Thu, 14 May 2009) | 1 line </p> </blockquote> <p> </p> <blockquote> <p> Fixes <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/2963" title="#2963: Bugs: Inspect tool fails when no errors are found (closed: fixed)">#2963</a> </p> </blockquote> <p> ........ </p> </description> <category>Ticket</category> </item> </channel> </rss>