Boost C++ Libraries: Ticket #3051: boost::variant should observe BOOST_NO_TYPEID and BOOST_NO_IOSTREAM

attachment set

anonymous — Tue, 19 May 2009 17:59:53 GMT

attachment → variant.hpp

Modified variant.hpp

attachment set

anonymous — Tue, 19 May 2009 18:00:45 GMT

attachment → variant.diff

variant.hpp diff w.r.t boost 1.38.0

Marshall Clow — Sun, 31 May 2009 06:36:30 GMT

This patch applies ok (though it should really be a full SVN diff), and rebuilding doesn't seem to cause any problems; at least the variant tests all pass. Tested on Mac OS X, gcc 4.0.1

severity changed

Daniel James — Sun, 31 May 2009 11:13:42 GMT

severity Showstopper → Problem

I'm attaching a new patch. It includes the changes to blank.hpp (as it seems to be part of variant - that it isn't documented or tested is another bug, all top level headers should have a link to their library's documentation). It also adds a couple of notes to reference documentation and fixes the tests for when BOOST_NO_TYPEID isn't defined. I tested it with the following in my user-config.jam:

using darwin : 4.4nortti : ccache g++-mp-4.4 -fno-rtti ;

BOOST_NO_IOSTREAM is harder to test as the tests rely heavily on it, but I tried a simple file which included STLport with _STLP_USE_NO_IOSTREAMS defined and it seemed okay.

attachment set

Daniel James — Sun, 31 May 2009 11:14:32 GMT

attachment → variant.patch

Patch for both variant and blank, with tests and a little documentation.

status changed; resolution set

Daniel James — Sat, 06 Jun 2009 11:46:26 GMT

status new → closed
resolution → fixed

(In [53682]) Support BOOST_NO_TYPEID and BOOST_NO_IOSTREAM in Boost.Variant. Fixes #3051.

Daniel James — Sat, 27 Jun 2009 07:34:44 GMT

(In [54398]) Support BOOST_NO_TYPEID and BOOST_NO_IOSTREAM in Boost.Variant. Fixes #3051.

Merged revisions 53682 via svnmerge from https://svn.boost.org/svn/boost/trunk

........

r53682 | danieljames | 2009-06-06 12:46:24 +0100 (Sat, 06 Jun 2009) | 1 line

Support BOOST_NO_TYPEID and BOOST_NO_IOSTREAM in Boost.Variant. Fixes #3051.

........