Boost C++ Libraries: Ticket #3078: Assert failure caused by property_map with BGL bundled properties if compiled in Debug mode in VS2008 SP1

attachment set

Mon, 25 May 2009 11:34:11 GMT

attachment → BGLTest.cpp

example to reproduce the rpoblem

attachment set

Mon, 25 May 2009 11:57:06 GMT

attachment → BGLTest.2.cpp

example to reproduce the problem (updated)

Jeremiah Willcock — Mon, 25 May 2009 18:18:14 GMT

This code is syntactically invalid. I fixed those issues but could not reproduce the problem under Valgrind on Linux. The GCC debug mode doesn't work on this code for unrelated reasons. I don't have access to VC 10. Do you have a simpler version that exhibits the problem? Please at least remove the randomness and unrelated code.

Mon, 25 May 2009 19:55:45 GMT

Replying to jewillco:

This code is syntactically invalid. I fixed those issues but could not reproduce the problem under Valgrind on Linux. The GCC debug mode doesn't work on this code for unrelated reasons. I don't have access to VC 10. Do you have a simpler version that exhibits the problem? Please at least remove the randomness and unrelated code.

I just made a simpler example but the error didn't appear... Perhaps this is something compiler-dependent? Could you please attach your version that you tested on Linux with my errors fixed so I can have a look?

attachment set

Jeremiah Willcock — Mon, 25 May 2009 20:01:34 GMT

attachment → BGLTest.3.cpp

Fixed version of test

Jeremiah Willcock — Mon, 25 May 2009 20:03:10 GMT

I attached that. It is compiler-dependent; I think VC 10's debug mode is like the GLibC++ debug mode that I can't get working because of Phoenix problems. Is there a simpler version that fails on VC 10?

Mon, 25 May 2009 20:53:20 GMT

Sorry about the errors, it compiled fine on Windows and I didn't test on Linux. I took your version and tried to simplify it a bit. It seems that even without bundled properties the error occurs.

attachment set

Mon, 25 May 2009 20:54:05 GMT

attachment → BGLTest.4.cpp

Simplified version

status changed; resolution set

Jeremiah Willcock — Mon, 25 May 2009 21:33:18 GMT

status new → closed
resolution → invalid

There are two issues with your code. The first one, that I think is causing your problem, is that you define a copy constructor that is empty and thus does not copy anything. Therefore, your graph and edge list are not copied when your visitor is passed into depth_first_visit (which is done by copy), leading to the edge list being empty and thus the iterator in your property map being invalid. The second issue is that you are storing the graph by copy in your visitor. This wastes memory, and also (although this may not show up with your graph type) some graph types have vertex descriptors that are tied to a particular graph. For example, using vertices from one graph to access edges or properties in a copy of that graph is invalid (and fails in subtle ways) for some instantiations of adjacency_list. I actually noticed the copy constructor issue when I went to store the graph by reference and the compiler complained about the copy constructor.

You should fix your problem in two ways:

Change PathRecorder to store "const Graph&" rather than "const Graph".
Remove the copy constructor and let the compiler-generated one (which works) be used, or add an explicit copy or reference of the edge data. Note that you may not want to do the default deep copy of that data; you might want to build the property map externally and only store it (and not its underlying data) in your visitor since property maps are copied shallowly.

Mon, 25 May 2009 21:53:12 GMT

Thanks a lot for your help, jewillco. Sorry for submitting invalid bug report.