Boost C++ Libraries: Ticket #3123: Support for serializing shared_ptr to const types

attachment set

Sohail Somani — Tue, 02 Jun 2009 21:54:15 GMT

attachment → serialization.diff

Patch to support loading and saving const shared_ptr

status changed; resolution set

Robert Ramey — Wed, 22 Jul 2009 15:42:03 GMT

status new → closed
resolution → invalid

Looking at the diff, I would rather call this "serialization of shared_ptr to a const type".

The subject if serialization of "const" members is addressed in general in the manual in the section Reference/SerializableConcept/ClassTypes/ClassMembers/constMembers.

From the documentation

"Saving const members to an archive requires no special considerations. Loading const members can be addressed by using a const_cast:

ar & const_cast<T &>(t);

Note that this violates the spirit and intention of the const keyword. const members are intialized when a class instance is constructed and not changed thereafter. However, this may be most appropriate in many cases. Ultimately, it comes down to the question about what const means in the context of serialization. "

Basically, "const" means the member isn't meant to be changeable. It would be in appropriate for the serialization library (or any other library) to violate the explicitly stated intention - especially without calling attention to that fact. It the developer want's to override the "const" the special case of serialization, he has the option of using const_cast to implement and document this desire.

If this used to work, it was an oversight which has since been corrected.

Robert Ramey

status changed; resolution deleted

Sohail Somani — Sun, 26 Jul 2009 15:53:28 GMT

status closed → reopened
resolution invalid

I have to disagree with you here. We are not touching a const object at all. The shared_ptr itself is non-const.

T *p; p is non-const T const *p; p is still non-const

shared_ptr<T> p; p is non-const shared_ptr<const T> p; p is still non-const

So what is the problem?

Sohail Somani — Sun, 26 Jul 2009 15:55:33 GMT

Replying to ramey:

Fixing formatting.

I have to disagree with you here. We are not touching a const object at all. The shared_ptr itself is non-const.

T *p; // p is non-const
T const *p; // p is still non-const

shared_ptr<T> p; // p is non-const
shared_ptr<const T> p; // p is still non-const

So what is the problem? I don't need a const-cast to mutate p in either case. This to me is a deficiency in the library not the user!

Sohail Somani — Sun, 26 Jul 2009 19:55:37 GMT

Replying to ramey:

Looking at the diff, I would rather call this "serialization of shared_ptr to a const type".

Yes, you are completely right about that. Bad wording on my part.

cc set

Sohail Somani — Sun, 26 Jul 2009 19:56:18 GMT

cc boost-trac@… added

Robert Ramey — Sun, 25 Oct 2009 19:03:24 GMT

Note that I've checked in changes which touch upon this issue. This should be tested again with the trunk or release branch versions.

Robert Ramey

Sohail Somani — Sun, 25 Oct 2009 23:20:33 GMT

Still doesn't seem to work. Can you point me to the revision where you checked in? Maybe I am checking out the wrong branch.

Thanks.

Robert Ramey — Mon, 21 Dec 2009 20:01:15 GMT

I'm taking another look at this.

The first thing that occurs to me is that this has nothing to do with shared_ptr serialization. The same situation occurs with anything like:

const B * b; ar & b;

I'm still looking at it.

Robert Ramey

Sohail Somani — Tue, 22 Dec 2009 14:46:54 GMT

Thanks, I appreciate it.

status changed; resolution set

Robert Ramey — Wed, 03 Feb 2010 21:54:11 GMT

status reopened → closed
resolution → fixed

I did manage to "fix" this. I had to include a blunt hack in iserializer.hpp to accomplish this. C++ is very, very reluctant to permit casting from const T a type T.