Boost C++ Libraries: Ticket #3215: Clamp function

status changed; owner set

Marshall Clow — Sat, 27 Jun 2009 18:28:55 GMT

owner set to Marshall Clow
status new → assigned

Marshall Clow — Sat, 27 Jun 2009 23:13:20 GMT

I just added "sandbox/boost/algorithm/clamp.hpp" Tests in "sandbox/libs/algorithm/clamp/test".

Let me know if that's what you wanted.

OlafvdSpek@… — Sun, 28 Jun 2009 09:47:37 GMT

Yes, except you put the value at the back instead of at the front, I'm not sure that's preferable.

Would it be better to use separate templated types for lo and hi to avoid the issues with std::max and std::min? The return type is clear in this case, the type of the original value.

OlafvdSpek@… — Sun, 28 Jun 2009 09:49:32 GMT

return val < lo ? lo : val < hi ? val : hi;

Should be:

return val < lo ? lo : hi < val ? hi : val;

Marshall Clow — Sun, 28 Jun 2009 17:24:44 GMT

I can see putting the value first, that's no problem.

However, I don't see the difference in the two code snippets. When hi == val, the first one returns hi, and the second one returns val. When comparing objects, the first calls val.operator< ( hi ), the second hi.operator< ( val ). So?

Sun, 28 Jun 2009 18:57:59 GMT

There is a difference when hi and val are equivalent but not equal. It's not an issue for simple types but it might be an issue in other cases.

Marshall Clow — Sun, 28 Jun 2009 23:05:42 GMT

Updated in the sandbox - revision 54484.

olafvdspek@… — Wed, 08 Jul 2009 09:19:47 GMT

Looks good.

olafvdspek@… — Wed, 08 Jul 2009 09:20:09 GMT

https://svn.boost.org/svn/boost/sandbox/boost/algorithm/clamp.hpp

milestone changed

olafvdspek@… — Wed, 22 Jul 2009 09:38:05 GMT

milestone Boost 1.40.0 → Boost 1.41.0

To which library will this function be added?

Marshall Clow — Wed, 22 Jul 2009 20:48:13 GMT

Boost.Algorithm; once it (the library) is reviewed and accepted.

status changed; resolution set

anonymous — Mon, 07 Jun 2010 09:51:31 GMT

status assigned → closed
resolution → invalid

This kind of request must be sent to the Boost ML, not the Trac.

I propose to close this ticket as this is more related to new features to the forthcoming Algorithm library.

status changed; resolution deleted

Olaf van der Spek — Mon, 07 Jun 2010 12:32:37 GMT

status closed → reopened
resolution invalid

I propose to close this ticket

Proposing isn't the same as doing... Why don't you reassign to the algorithm lib?

viboes — Mon, 07 Jun 2010 14:38:35 GMT

Replying to Olaf van der Spek:

I propose to close this ticket

Proposing isn't the same as doing... Why don't you reassign to the algorithm lib?

There is no Algorithm library. So no need to make defects on libraries that doesn't exists. If you can not assign a component, maybe you should close the ticket yourself.

anonymous — Mon, 07 Jun 2010 18:42:16 GMT

It's a feature request, not a bug report.

viboes — Tue, 08 Jun 2010 08:27:28 GMT

Replying to anonymous:

It's a feature request, not a bug report.

There is Library Submissions for that, I think.

anonymous — Tue, 08 Jun 2010 11:55:01 GMT

No, that's for submitting a library, not for requesting a function.

viboes — Mon, 29 Nov 2010 15:38:44 GMT

It is not useful to make a request that nobody can handle :) Please close it yourself.

anonymous — Mon, 29 Nov 2010 15:40:05 GMT

marshall appears to be handling it. What's the problem?

Marshall Clow — Mon, 29 Nov 2010 15:45:35 GMT

The reason that I assigned this ticket to myself is that I have implemented this in the (proposed) Boost.Algorithms library, which I will post a version 0.1 on the man list "REAL SOON NOW".

sorokin@… — Mon, 21 Mar 2011 22:01:54 GMT

So, will this function be included in boost?

Marshall Clow — Sun, 03 Apr 2011 03:51:27 GMT

See <http://lists.boost.org/Archives/boost/2011/03/179561.php>

component, milestone changed

Marshall Clow — Mon, 09 Jan 2012 18:27:13 GMT

component None → algorithm
milestone Boost 1.41.0 → Boost 1.50.0

Checked into trunk in [76388]. Will close ticket when merged to release (which will be for 1.50 release)

status changed; resolution set

Marshall Clow — Wed, 23 May 2012 16:25:51 GMT

status reopened → closed
resolution → fixed

(In [78557]) Merged changes for Boost.Algorithm to release; Fixes #6596; Fixes #6689; Fixes #3215; Fixes #6840

Tue, 19 Jun 2012 11:05:48 GMT

Is this supposed to be available in namespace boost or just in boost::algorithm?

Marshall Clow — Tue, 19 Jun 2012 13:08:31 GMT

boost::algorithm

All the algorithms in Boost.Algorithm are in that namespace.

Tue, 19 Jun 2012 14:34:07 GMT

Why's that? String functions, like to_upper, are in boost itself.