Boost C++ Libraries: Ticket #3244: XLC warnings about missing "private" keyword when extending boost::noncopyable

viboes — Fri, 20 Nov 2009 11:20:48 GMT

Replying to Ioannis Papadopoulos <ipapadop@…>:

xlc 10.1 throws warnings whenever boost::mutex and boost::recursive_mutex are used because of missing access specifier.

Example output:

"/usr/local/include/boost/thread/pthread/mutex.hpp", line 30.9: 1540-0198 (W) The omitted keyword "private" is assumed for base class "boost::noncopyable".

Could you show an example?

viboes — Tue, 08 Jun 2010 22:02:09 GMT

Following the update to follow more closely C++0X delete operation, instead of inheriting from boost::noncopyable, we can replace by the explicit private constructors

private:

mutex(mutex const&); mutex& operator=(mutex const&);

See attachments.

attachment set

viboes — Tue, 08 Jun 2010 22:24:32 GMT

attachment → 3244.patch

attachment set

viboes — Tue, 08 Jun 2010 23:11:05 GMT

attachment → 3244_2.patch

Correct issue with thread_group default constructor on 4344.patch

viboes — Tue, 08 Jun 2010 23:12:28 GMT

Replying to viboes:

See attachments.

Take 3244_2.patch, 3244.patch has a bug on thread_group default constructor.

type changed

viboes — Wed, 09 Jun 2010 01:02:01 GMT

type Bugs → Patches

status changed; resolution set

Anthony Williams — Wed, 09 Jun 2010 06:58:34 GMT

status new → closed
resolution → fixed

Fixed on trunk.