Boost C++ Libraries: Ticket #3365: Serialization of multi_index_container is non portable.

status changed; resolution set

Joaquín M López Muñoz — Thu, 03 Sep 2009 12:12:01 GMT

status new → closed
resolution → fixed

(In [55994]) fixed #3365

Joaquín M López Muñoz — Thu, 03 Sep 2009 12:14:00 GMT

Ilia, just fixed the problem in changeset

https://svn.boost.org/trac/boost/changeset/55994

I'd appreciate if you could check everything's OK on your side.

status, severity changed; cc set; resolution deleted

Wed, 23 Nov 2011 09:32:18 GMT

cc mailinglists@… added
status closed → reopened
resolution fixed
severity Cosmetic → Problem

The changeset may fix this problem (haven't checked), but line 667 (of this changeset) might cause data truncation under x64 bit and a compiler warning.

    serialization::collection_size_type       s;
    detail::serialization_version<value_type> value_version;
    if(version<1){
      std::size_t sz;
      ar>>serialization::make_nvp("count",sz);
      s=sz;  /***** Error here *****/
    }

With x64 bit compilation (Visual Studio 2008, boost 1.44) collection_size_type is unsigned int (32 Bit), whereas size_t is an unsigned long (64 Bit). The assignment s=sz gets truncated and issues a warning

boost\boost/multi_index_container.hpp(673) : error C4267: 'argument' : conversion from 'size_t' to 'const unsigned int', possible loss of data

Since our project treats this warning as an error, the code does not compile.

The patch here is straightforward: simply cast the result. There is nothing we can do in this case anyway and also it is pretty unlikely that any user in the world will serialise more than 2^{32 items.}

@@ -670,7 +670,7 @@
     if(version<1){
       std::size_t sz;
       ar>>serialization::make_nvp("count",sz);
-      s=sz;
+      s=(serialization::collection_size_type)sz;
     }
     else{
       ar>>serialization::make_nvp("count",s);

Joaquín M López Muñoz — Thu, 24 Nov 2011 08:09:35 GMT

Hi Hajo,

Please check whether

https://svn.boost.org/trac/boost/changeset/75643

solves the issue. Thank you!

Thu, 24 Nov 2011 09:22:24 GMT

Hi Joaquin, yes, that should solve the issue. Thanks. And thanks for your work :-) (fixed in 1.49) You can close this ticket again...

status changed; resolution set

Joaquín M López Muñoz — Thu, 24 Nov 2011 09:24:41 GMT

status reopened → closed
resolution → fixed