Boost C++ Libraries: Ticket #3553: Changeset 57125 broke Proto

attachment set

Christopher Schmidt — Sat, 24 Oct 2009 11:11:47 GMT

attachment → proto.diff

component changed; owner set

Christopher Schmidt — Sat, 24 Oct 2009 11:14:37 GMT

owner set to Eric Niebler
component None → proto

Eric Niebler — Sat, 24 Oct 2009 14:09:37 GMT

Why is the patch testing for BOOST_VERSION < 103500?

anonymous — Sat, 24 Oct 2009 14:20:59 GMT

If BOOST_VERSION < 103500, the spirit fusion library is used, which uses the old interface. See fold.hpp and toy_spirit2.cpp

Eric Niebler — Sat, 24 Oct 2009 14:28:03 GMT

But the argument order for fusion::fold's binary function won't be changing until the next version of Boost, right? Have you testing this patch with Boost 1.40?

anonymous — Sat, 24 Oct 2009 15:08:08 GMT

But the argument order for fusion::fold's binary function won't be changing until the next version of Boost, right?

No, I just committed this patch to the trunk and I will commit it to the 1.42 release branch. This patch should not affect 1.41.

Have you testing this patch with Boost 1.40?

I did test this patch with the HEAD of the trunk. I assumed if a proto snapshot is that up-to-date that it contains this patch, there will also be an up-to-date snapshot of Fusion available, or (due to whatever reasons) Boost < 1.35 will be used. Is this assumption incorrect?

I think its ok to apply the patch so the trunk is not broken. Once BOOST_VERSION is set to 104200, I will create another patch to change the

#if BOOST_VERSION < 103500

in the functors to

#if BOOST_VERSION < 104200

Is that OK for you?

I am sorry for any inconvenience caused.

Christopher Schmidt — Sat, 24 Oct 2009 15:10:05 GMT

Oh, I did not log in. The last two "anonymous" posts are mine.

Eric Niebler — Mon, 26 Oct 2009 14:14:23 GMT

The goal with the version checks is so that newer versions of Proto can work with older versions of Boost. That's arguably not that important now that Proto is an official part of Boost and has been for a while. Please make the change without any version checks. I'll go through and remove all other such version checks. That code is untested and likely broken anyway.

Thanks.

status changed; resolution set

Eric Niebler — Mon, 26 Oct 2009 15:15:12 GMT

status new → closed
resolution → fixed

(In [57159]) accomodate recent change to fusion::fold, remove old support for Doxygen and pre-1.35 Fusion, fixes #3553