Boost C++ Libraries: Ticket #3602: created pch.cpp file is missing a terminating newline.

attachment set

Vladimir Prus — Mon, 09 Nov 2009 18:15:22 GMT

attachment → msvc.diff

Vladimir Prus — Mon, 09 Nov 2009 18:16:23 GMT

Paul, does the attached patch help? Please note you need current Boost.Jam -- you can get that by running 'bootstrap.bat' in the root of boost source tree.

status changed

Vladimir Prus — Mon, 09 Nov 2009 18:16:38 GMT

status new → assigned

anonymous — Tue, 10 Nov 2009 12:04:46 GMT

Sadly not quite

pch.pch.cpp ..\..\..\bin.v2\libs\math\test\msvc-9.0\debug\asynch-exceptions-on\threading-multi\pch.pch.cpp(1) : warning C4067: unexpected tokens following preprocessor directive - expected a newline ..\..\..\bin.v2\libs\math\test\msvc-9.0\debug\asynch-exceptions-on\threading-multi\pch.pch.cpp(1) : fatal error C1004: unexpected end-of-file found

pch.pch.cpp contains:

#include "pch.hpp"\n

So isn't translating the \n into a newline :-(

(using bjam 3.1.17 I believe

status changed; resolution set

Vladimir Prus — Fri, 27 Nov 2009 06:43:06 GMT

status assigned → closed
resolution → fixed

(In [57965]) When generating PCH-compiling cpp, end it with newline.

Fixes #3602.

Paul A. Bristow — Fri, 27 Nov 2009 16:17:29 GMT

Replying to vladimir_prus:

(In [57965]) When generating PCH-compiling cpp, end it with newline.

Fixes #3602.

Confirms Works OK for me with jamfile including requirements

<toolset>msvc:<cxxflags>/Za # disable MS Extensions in Boost.Test

cpp-pch pch : pch.hpp : <use>../../test/buildboost_test_exec_monitor ;

that failed before.

Thanks.