Boost C++ Libraries: Ticket #3630: building bjam with custom CFLAGS fails if $CFLAGS contains extra white space

cc set

ohnobinki@… — Sun, 06 Dec 2009 02:07:14 GMT

cc ohnobinki@… added

attachment set

ohnobinki@… — Sun, 06 Dec 2009 07:13:27 GMT

attachment → boost-build-flags-unescape.patch

fixes compilation for >=boost-build-0.39 for me

version, component, milestone changed; owner set

René Rivera — Thu, 07 Jan 2010 03:10:01 GMT

owner set to René Rivera
version Boost 1.40.0 → Boost.Jam 3.1.16
component None → bjam
milestone Boost 1.41.0 → Boost.Jam 3.1.18

owner, component changed

Vladimir Prus — Sun, 10 Jan 2010 21:05:33 GMT

owner changed from René Rivera to Vladimir Prus
component bjam → build

owner, component changed

René Rivera — Thu, 04 Mar 2010 16:28:50 GMT

owner changed from Vladimir Prus to René Rivera
component build → bjam

status changed; resolution set

René Rivera — Fri, 19 Mar 2010 15:04:50 GMT

status new → closed
resolution → worksforme

I can't seem to reproduce the problem on the latest bjam 3.1.18. Although I don't have access to a Gentoo system, so I'm only trying it on a MacOSX bash. I don't see the extra "" in CFLAGS when I force the cc toolset.

status changed; resolution deleted

Mon, 22 Mar 2010 08:22:08 GMT

status closed → reopened
resolution worksforme

The problem is still there. For some reason the CFLAGS in my steps to reproduce don't contain extra white spaces. You need something like:

export CFLAGS="-O2 -pipe "

This happens with the bjam shipped with boost 1.42 on linux with bash 4.0.35 (older bash versions were affected too).

status changed; resolution set

René Rivera — Mon, 22 Mar 2010 15:26:46 GMT

status reopened → closed
resolution → fixed

(In [60768]) Fix possible problems when trailing or leading whitespace is added to the env vars used, for example CC and CFLAGS when using the cc toolset. Even though I can't get compilation to fail even with the extra whitespace during building it does seem to fail for some compilers that don't ignore the whitespace arguments. (Fixes #3630)

Mon, 22 Mar 2010 19:00:14 GMT

The patch works, thank you. Could you please add LDFLAGS to list of checked variables? It's affected too.

Mon, 22 Mar 2010 19:04:51 GMT

Oh, I missed that we inject the user's LDFLAGS through the LIBS variable. That means LIBS needs to be in this list. Thank you.

status changed; resolution deleted

ohnobinki@… — Tue, 20 Jul 2010 17:06:52 GMT

status closed → reopened
resolution fixed

I think that LIBS still needs to be fixed(?)

component changed

René Rivera — Thu, 31 Mar 2011 00:58:00 GMT

component bjam → build

status changed; resolution set

René Rivera — Fri, 02 Jan 2015 16:22:03 GMT

status reopened → closed
resolution → fixed

Turns out this was fixed long ago.